Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CodeNotate #138

Merged
merged 3 commits into from
Mar 19, 2025
Merged

Add CodeNotate #138

merged 3 commits into from
Mar 19, 2025

Conversation

ross-kunaico
Copy link
Collaborator

  • Add dev dependencies
  • Update some references
  • Change from api.ts to api.json files, following the updated strategy from CodeNotate. The main reason for the change is that the json formatting is more consistent/predictable and therefore more apt for parsing. Specifically, when they were .ts files, the biome formatter was changing escaped double quotes inside double quotes to double quotes inside single quotes, and that was causing problems when trying to parse the api objects as json.

rossacheson and others added 3 commits March 18, 2025 09:49
Co-authored-by: Ross Acheson <rossacheson@users.noreply.github.com>

Co-authored-by: Ross Acheson <rossacheson@users.noreply.github.com>
Co-authored-by: Ross Acheson <rossacheson@users.noreply.github.com>
Co-authored-by: Ross Acheson <rossacheson@users.noreply.github.com>
Copy link

changeset-bot bot commented Mar 18, 2025

⚠️ No Changeset found

Latest commit: 86e2370

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@thejackshelton-kunaico
Copy link
Collaborator

thejackshelton-kunaico commented Mar 19, 2025

LGTM

image

You can merge whenever. Also if we could hook up the onClick$ of these buttons to a server function that calls the CLI commands

The drawer shows when clicking the magic wand icon in dev mode.

@ross-kunaico
Copy link
Collaborator Author

@thejackshelton thanks for the review! Added the onClick$ handling to the TODO list 👍

@ross-kunaico ross-kunaico merged commit 8886fa9 into main Mar 19, 2025
3 checks passed
@ross-kunaico ross-kunaico deleted the code-notate branch March 19, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants