Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6641-bring records till s_8 #7

Merged
merged 10 commits into from
Jul 6, 2021
Merged

6641-bring records till s_8 #7

merged 10 commits into from
Jul 6, 2021

Conversation

lav-patel
Copy link
Member

No description provided.

@lav-patel lav-patel self-assigned this Jul 3, 2021
@lav-patel lav-patel changed the title issue fix by limiting only bringing records till s8 bring records till s_8 Jul 4, 2021
@lav-patel lav-patel changed the title bring records till s_8 6641-bring records till s_8 Jul 6, 2021
mkpennemays
mkpennemays approved these changes Jul 6, 2021
View reviewed changes
Copy link

@mkpennemays mkpennemays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am only reviewing the changes in ds_status_sync.py, which the changes applicable for the problem.
These changes, to select only the fields we want, look good.

@lav-patel
Copy link
Member Author

FYI: rest of the changes are related to code quality checks.

@lav-patel lav-patel merged commit c31734a into master Jul 6, 2021
@lav-patel lav-patel deleted the 6641-ds-sync-fails-due-to-new-fields branch July 6, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkpennemays mkpennemays mkpennemays approved these changes

@schandaka schandaka Awaiting requested review from schandaka

Assignees

@lav-patel lav-patel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lav-patel @mkpennemays