Fix history corruption due to deletion of events (uber#1087)

* Fix history corruption due to deletion of events
kumar-sundaram · Sep 5, 2018 · 986e93c · 986e93c
1 parent e488d84
commit 986e93c
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/service/history/historyReplicator.go b/service/history/historyReplicator.go
@@ -654,7 +654,7 @@ func (r *historyReplicator) replicateWorkflowStarted(ctx context.Context, contex
 		return nil
 	}
 	if _, ok := err.(*persistence.WorkflowExecutionAlreadyStartedError); !ok {
-		deleteHistory()
+		logger.WithField(logging.TagErr, err).Info("Create workflow failed after appending history events.")
 		return err
 	}
 

diff --git a/service/history/historyReplicator_test.go b/service/history/historyReplicator_test.go
@@ -1367,7 +1367,6 @@ func (s *historyReplicatorSuite) TestReplicateWorkflowStarted_ISE() {
 	sBuilder.On("getTransferTasks").Return(transferTasks)
 	sBuilder.On("getTimerTasks").Return(timerTasks)
 	s.mockShardManager.On("UpdateShard", mock.Anything).Return(nil).Once() // this is called when err is returned, and shard will try to update
-	s.mockHistoryMgr.On("DeleteWorkflowExecutionHistory", mock.Anything).Return(nil).Once()
 
 	errRet := &shared.InternalServiceError{}
 	// the test above already assert the create workflow request, so here jsut use anyting