Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kuma-cp): clone outbound tags #9592

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Mar 13, 2024

Checklist prior to review

There was an error:

fatal error: concurrent map writes
  
  goroutine 11569 [running]:
  github.com/kumahq/kuma/pkg/xds/generator.buildOutboundsWithMultipleIPs(0xc00325f878, {0xc002dbca10, 0x2, 0x10?}, {0xc001d88230, 0x2, 0x307ee20?})
  	github.com/kumahq/kuma/pkg/xds/generator/outbound_proxy_generator.go:475 +0x253
  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
@lukidzi lukidzi requested a review from a team as a code owner March 13, 2024 13:47
@lukidzi lukidzi requested review from jijiechen, michaelbeaumont, bartsmykla and jakubdyszkiewicz and removed request for a team March 13, 2024 13:47
@lukidzi lukidzi enabled auto-merge (squash) March 13, 2024 14:50
@lukidzi lukidzi merged commit b839cad into kumahq:master Mar 13, 2024
29 checks passed
Copy link
Contributor

github-actions bot commented Mar 13, 2024

backporting to release-2.5 with action

backporting to release-2.4 with action
backporting to release-2.6 with action

kumahq bot pushed a commit that referenced this pull request Mar 13, 2024
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
kumahq bot pushed a commit that referenced this pull request Mar 13, 2024
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
kumahq bot pushed a commit that referenced this pull request Mar 13, 2024
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
kumahq bot pushed a commit that referenced this pull request Mar 13, 2024
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
kumahq bot pushed a commit that referenced this pull request Mar 13, 2024
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
lukidzi added a commit that referenced this pull request Mar 13, 2024
fix(kuma-cp): clone outbound tags (#9592)

Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
Co-authored-by: Lukasz Dziedziak <lukidzi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants