Skip to content

feat(api): rename zone-ingress/global-secrets to k8s conventions name #13418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Apr 16, 2025

Motivation

While working on the missing ingress config dump, I noticed a lack of consistency in resource names. The naming differs between inspect and get. We should be consistent, especially since we previously made a change for this purpose, but this resource wasn't covered at the time.

Implementation information

Introduced a new field in the description that allows users to provide an alias for the path/kumactl command. We then create endpoints for the alias and also include it in the kumactl command.

It shouldn't break the old kumactl since we have 2 endpoints zone-ingresses and zoneingresses, but the new client does requests to zoneingresses.

Other ideas:
Should we return a 301 when someone calls zone-ingresses instead of registering two endpoints?

Supporting documentation

Fix #13359

lukidzi added 2 commits April 16, 2025 08:33
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
@lukidzi lukidzi changed the title Deprecate proto and resource naming feat(api): rename zone-ingress to zoneingress and introduce alias Apr 16, 2025
@lukidzi lukidzi requested a review from lahabana April 16, 2025 15:24
Copy link
Contributor

Reviewer Checklist

🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
If something doesn't apply please check the box and add a justification if the reason is non obvious.

  • Is the PR title satisfactory? Is this part of a larger feature and should be grouped using > Changelog?
  • PR description is clear and complete. It Links to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as an image registry)
  • IPv6 is taken into account (.e.g: no string concatenation of host port)
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Don't forget ci/ labels to run additional/fewer tests
  • Does this contain a change that needs to be notified to users? In this case, UPGRADE.md should be updated.
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)

Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
@lukidzi lukidzi changed the title feat(api): rename zone-ingress to zoneingress and introduce alias feat(api): rename zone-ingress/global-secrets to k8s compatible name Apr 16, 2025
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
@lukidzi lukidzi changed the title feat(api): rename zone-ingress/global-secrets to k8s compatible name feat(api): rename zone-ingress/global-secrets to k8s conventions name Apr 16, 2025
@lukidzi lukidzi marked this pull request as ready for review April 22, 2025 12:28
@lukidzi lukidzi requested a review from a team as a code owner April 22, 2025 12:28
@lukidzi lukidzi requested a review from lobkovilya April 22, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Naming for resource is not following k8s pattern
1 participant