-
Notifications
You must be signed in to change notification settings - Fork 340
feat(xds): introduce deltaXds for configuration exchange #13356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
Reviewer Checklist🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
|
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
are we waiting for this? |
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
I've just merged it and relased. Ready to review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's quite big PR, I'll have another round tomorrow
pkg/plugins/runtime/k8s/controllers/testdata/pod_controller/dataplane-for-pod.golden.yaml
Show resolved
Hide resolved
pkg/xds/bootstrap/testdata/generator.custom-config-minimal-request-and-delta.golden.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general I think it's fine. I'm thinking about migration - is per DPP annotation enough? Would we want something per namespace? 🤔
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
Motivation
Envoy supports incremental xDS, which sends only changes rather than the entire state.
Implementation information
Needs fix for warming cluster: kumahq/go-control-plane#15
Envoy
to Dataplane/ZoneIngress/ZoneEgress resource to be able to enable delta for single SidecarNote
Increased the memory of control-plane since with delta it requires more memory
Supporting documentation
Fix ##13366