revert(kuma-cp): do not use additional addresses #11601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
lukidzi
requested review from
bartsmykla and
lobkovilya
and removed request for
a team
kumahq bot
pushed a commit
that referenced
this pull request
Oct 1, 2024
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
kumahq bot
pushed a commit
that referenced
this pull request
Oct 1, 2024
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
kumahq bot
pushed a commit
that referenced
this pull request
Oct 1, 2024
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
kumahq bot
pushed a commit
that referenced
this pull request
Oct 1, 2024
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
lukidzi
pushed a commit
that referenced
this pull request
Oct 1, 2024
slonka
pushed a commit
that referenced
this pull request
Oct 1, 2024
…#11612) * revert(kuma-cp): do not use additional addresses (#11601) Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com> * resolve conflict Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com> --------- Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com> Co-authored-by: Lukasz Dziedziak <lukidzi@gmail.com>
slonka
pushed a commit
that referenced
this pull request
Oct 1, 2024
…#11609) * revert(kuma-cp): do not use additional addresses (#11601) Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com> * resolve conflict Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com> --------- Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com> Co-authored-by: Lukasz Dziedziak <lukidzi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist prior to review
When using TrafficRoute, a user might encounter an issue with address conflicts in the listeners. If the vips-config-map (which holds internal VIPs) is removed, the control plane attempts to rebuild it. However, the order in which the map is rebuilt may differ from the addresses previously allocated and delivered by the control plane to the sidecars. If a sidecar runs with listeners that have additional addresses defined, and the rebuilt map assigns a different IP to a service, this IP mismatch can cause a conflict. As a result, the listener may be rejected by Envoy.
revert: #8796
syscall.Mkfifohave equivalent implementation on the other OS --ci/labels to run additional/fewer testsUPGRADE.md? --