Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2e): dont wait for observability namespace termination #11550

Merged

Conversation

Automaat
Copy link
Contributor

@Automaat Automaat commented Sep 25, 2024

We don't need to wait for observability namespace termination, it can be best effort, and even if we fail it will be removed alongside with cluster at the end of tests

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

Changelog: skip

Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
@Automaat Automaat requested a review from a team as a code owner September 25, 2024 08:15
@Automaat Automaat requested review from jijiechen and michaelbeaumont and removed request for a team September 25, 2024 08:15
@Automaat
Copy link
Contributor Author

@Automaat Automaat enabled auto-merge (squash) September 25, 2024 08:49
@Automaat Automaat merged commit 9a5e722 into kumahq:master Sep 25, 2024
15 checks passed
@Automaat Automaat deleted the fix/best-effort-observability-ns-removal branch September 25, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants