Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(resourcerules): add own mesh to the MeshContext, so it could be successfully resolved #11525

Merged

Conversation

lobkovilya
Copy link
Contributor

@lobkovilya lobkovilya commented Sep 23, 2024

Checklist prior to review

…uccessfully resolved

Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya lobkovilya requested a review from a team as a code owner September 23, 2024 20:18
@lobkovilya lobkovilya requested review from jijiechen and lukidzi and removed request for a team September 23, 2024 20:18
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good but if I understand #11512 the really basic case seems to be broken. We've got here because we missed the test. Can we add it?

Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd strongly argue for keeping the OtherMeshes method and adding a new Meshes method as it would make the change simpler but also makes the API less error prone

Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
pkg/xds/context/resources.go Show resolved Hide resolved
@lobkovilya lobkovilya merged commit 3ba8e86 into kumahq:master Sep 25, 2024
15 checks passed
@lobkovilya lobkovilya deleted the fix/dont-exclude-own-mesh-from-ctx branch September 25, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

to[].targetRef: Mesh doesn't work, even though it shows up in Inspect API
3 participants