Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): traffic route test with default tr policy #11523

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

jakubdyszkiewicz
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz commented Sep 23, 2024

Checklist prior to review

Because there was no default traffic route policy, we were switching back and forth between old and new xds code path resulting in listener clash (old path uses additional addresses, new does not). It's not 100% clear why exactly this was the cause, but the test is much more stable now. It's not a real world scenario to switch between old and new path very quickly.

I still saw some flake with error code 6. It's a DNS error caused by conntrack which we don't have a fix for #3459 (comment) in universal e2e tests

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@jakubdyszkiewicz jakubdyszkiewicz added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Sep 23, 2024
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz removed the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Sep 24, 2024
@jakubdyszkiewicz jakubdyszkiewicz marked this pull request as ready for review September 24, 2024 08:47
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner September 24, 2024 08:47
@jakubdyszkiewicz jakubdyszkiewicz requested review from jijiechen and lobkovilya and removed request for a team September 24, 2024 08:47
@jakubdyszkiewicz jakubdyszkiewicz merged commit a060222 into master Sep 24, 2024
16 checks passed
@jakubdyszkiewicz jakubdyszkiewicz deleted the traffic-route-test branch September 24, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants