Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transparent-proxy): remove deprecated outbound port exclusions opts #10983

Conversation

bartsmykla
Copy link
Contributor

  • Removed --exclude-outbound-tcp-ports-for-uids and --exclude-outbound-udp-ports-for-uids flags from kumactl install transparent-proxy.
  • Removed annotations traffic.kuma.io/exclude-outbound-tcp-ports-for-uids and traffic.kuma.io/exclude-outbound-udp-ports-for-uids in favor of traffic.kuma.io/exclude-outbound-ports-for-uids.

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS
    • It won't
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Tests were updated
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md?
    • Updated
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)
    • There is no need

Changelog: feat(transparent-proxy): remove deprecated flags and annotations for outbound port exclusions for UIDs

- Removed `--exclude-outbound-tcp-ports-for-uids` and `--exclude-outbound-udp-ports-for-uids` flags from `kumactl install transparent-proxy`.
- Removed annotations `traffic.kuma.io/exclude-outbound-tcp-ports-for-uids` and `traffic.kuma.io/exclude-outbound-udp-ports-for-uids` in favor of `traffic.kuma.io/exclude-outbound-ports-for-uids`.

Signed-off-by: Bart Smykla <bartek@smykla.com>
@bartsmykla bartsmykla added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Jul 25, 2024
@bartsmykla bartsmykla requested a review from a team as a code owner July 25, 2024 09:46
@bartsmykla bartsmykla requested review from jijiechen and lukidzi and removed request for a team July 25, 2024 09:46
@bartsmykla bartsmykla enabled auto-merge (squash) July 25, 2024 09:48
@bartsmykla bartsmykla merged commit 260df7f into master Jul 25, 2024
38 checks passed
@bartsmykla bartsmykla deleted the feat/remove-deprecated-tproxy-exclude-outbound-x-ports-for-uids-flags branch July 25, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants