Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(meshgateway): do not override annotations from deployment #10698

Merged
merged 1 commit into from
Jul 2, 2024
Merged

fix(meshgateway): do not override annotations from deployment #10698

merged 1 commit into from
Jul 2, 2024

Conversation

Automaat
Copy link
Contributor

@Automaat Automaat commented Jul 1, 2024

This fixes problems with using kubernetes rollout restart

Fixes: #9476

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@Automaat
fix(meshgateway): do not override annotations from deployment, this c…
d7de3a1 
…an cause problems with using kubernetes rollout restart

Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
@Automaat Automaat requested a review from a team as a code owner July 1, 2024 15:06
@Automaat Automaat requested review from lobkovilya and lukidzi and removed request for a team July 1, 2024 15:06
@Automaat Automaat merged commit b53663d into kumahq:master Jul 2, 2024
15 checks passed
@Automaat Automaat deleted the fix/rollout-restart-for-mesh-gateway branch July 2, 2024 05:28
@lahabana lahabana added backport and removed backport labels Oct 2, 2024
@kumahq kumahq deleted a comment from github-actions bot Oct 2, 2024
@kumahq kumahq deleted a comment from github-actions bot Oct 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024 •
edited
Loading

backporting to release-2.6 with action

backporting to release-2.7 with action
backporting to release-2.8 with action
backporting to release-2.8 with action
backporting to release-2.5 with action
backporting to release-2.5 with action
backporting to release-2.6 with action

kumahq bot pushed a commit that referenced this pull request Oct 2, 2024
@Automaat @kumahq
fix(meshgateway): do not override annotations from deployment (#10698)
82a1815 
fix(meshgateway): do not override annotations from deployment, this can cause problems with using kubernetes rollout restart

Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
kumahq bot pushed a commit that referenced this pull request Oct 2, 2024
@Automaat @kumahq
fix(meshgateway): do not override annotations from deployment (#10698)
453c486 
fix(meshgateway): do not override annotations from deployment, this can cause problems with using kubernetes rollout restart

Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
kumahq bot pushed a commit that referenced this pull request Oct 2, 2024
@Automaat @kumahq
fix(meshgateway): do not override annotations from deployment (#10698)
8d15f08 
fix(meshgateway): do not override annotations from deployment, this can cause problems with using kubernetes rollout restart

Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
@kumahq kumahq bot mentioned this pull request Oct 2, 2024
Merged
kumahq bot pushed a commit that referenced this pull request Oct 2, 2024
@Automaat @kumahq
fix(meshgateway): do not override annotations from deployment (#10698)
6007b2f 
fix(meshgateway): do not override annotations from deployment, this can cause problems with using kubernetes rollout restart

Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
This was referenced Oct 2, 2024
Merged
Merged
Merged
Automaat added a commit that referenced this pull request Oct 2, 2024
@kumahq @Automaat
fix(meshgateway): do not override annotations from deployment (backpo…
5747944 
…rt of #10698) (#11619)

fix(meshgateway): do not override annotations from deployment (#10698)

fix(meshgateway): do not override annotations from deployment, this can cause problems with using kubernetes rollout restart

Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
Co-authored-by: Marcin Skalski <marcin.skalski@konghq.com>
lahabana pushed a commit that referenced this pull request Oct 2, 2024
@kumahq @Automaat
fix(meshgateway): do not override annotations from deployment (backpo…
e8dfe5f 
…rt of #10698) (#11617)

fix(meshgateway): do not override annotations from deployment (#10698)

fix(meshgateway): do not override annotations from deployment, this can cause problems with using kubernetes rollout restart

Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
Co-authored-by: Marcin Skalski <marcin.skalski@konghq.com>
lahabana pushed a commit that referenced this pull request Oct 2, 2024
@kumahq @Automaat
fix(meshgateway): do not override annotations from deployment (backpo…
237db5b 
…rt of #10698) (#11618)

fix(meshgateway): do not override annotations from deployment (#10698)

fix(meshgateway): do not override annotations from deployment, this can cause problems with using kubernetes rollout restart

Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
Co-authored-by: Marcin Skalski <marcin.skalski@konghq.com>
lahabana pushed a commit that referenced this pull request Oct 2, 2024
@kumahq @Automaat
fix(meshgateway): do not override annotations from deployment (backpo…
4ed0bd8 
…rt of #10698) (#11616)

fix(meshgateway): do not override annotations from deployment (#10698)

fix(meshgateway): do not override annotations from deployment, this can cause problems with using kubernetes rollout restart

Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
Co-authored-by: Marcin Skalski <marcin.skalski@konghq.com>
@BrewTestBot BrewTestBot mentioned this pull request Oct 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Icarus9913 Icarus9913 Icarus9913 approved these changes

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

@lobkovilya lobkovilya Awaiting requested review from lobkovilya lobkovilya is a code owner automatically assigned from kumahq/kuma-maintainers

@lukidzi lukidzi Awaiting requested review from lukidzi lukidzi is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rollout restart doesn't work on deployment behind a MeshGatewayInstance
4 participants
@Automaat @michaelbeaumont @Icarus9913 @lahabana