Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(meshmultizoneservice): vip allocation #10667

Merged

Conversation

jakubdyszkiewicz
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz commented Jun 27, 2024

Checklist prior to review

VIP allocation for MeshMultiZoneService. Instead of copy-pasting it third time I refactored it so we only pass CIDRs and resource types to the allocator.

xref #10507

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

Changelog: feat(MeshMultizoneService): support multizone deployments of mesh services.

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
…ocation

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz marked this pull request as ready for review June 28, 2024 13:43
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner June 28, 2024 13:43
@jakubdyszkiewicz jakubdyszkiewicz requested review from michaelbeaumont and slonka and removed request for a team June 28, 2024 13:43
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakubdyszkiewicz jakubdyszkiewicz merged commit b058166 into kumahq:master Jul 1, 2024
16 checks passed
@jakubdyszkiewicz jakubdyszkiewicz deleted the feat/mzms-vip-allocation branch July 1, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants