chore(dns): remove empty dns port completely #10338
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to #8640, we have drop usage of empty dns port carefully and left some properties for
rollback/downgrade
. Nowadays, we gonna remove it completely.close #8639
Elaboration
What does
EmptyDNSPort
do?Refer to the first PR generate DNS filter, we introduced Envoy DNS filter. But at that time, there was no way to disable upstream resolvers in DNSFilter thus we used the coreDNS Empty DNS port as a dummy resolver to respond the empty response.
Later we found
Users can disable external DNS resolution by omitting the client configuration object.
from https://www.envoyproxy.io/docs/envoy/latest/configuration/listeners/udp_filters/dns_filter , which corresponds to the previous PR source codes change https://github.com/kumahq/kuma/pull/8640/files#diff-4188e1209c75b5064ff4c5f6b33180cb84e164a99021efa1fa01d2938e06e1f1L55-L80Why didn't we drop it completely by chore(dns): drop usage of empty dns port #8640 ?
Due to the first PR codes https://github.com/kumahq/kuma/pull/1807/files#diff-4cf14047d8fdc54a2debb5bfa2b95f2f5cccc7d48d7803cf3700ff2934ad86cbR23-R25 , it would not generate the configurations
If we totally removed the
EmptyDNSPort
from the previous PR #8640 and the user downgrade to a earlier CP version, the user must meet theif condition
and return nil empty configuration which leads to interruption in the traffic.Checklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OS --ci/
labels to run additional/fewer testsUPGRADE.md
? --