Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(meshservice): ipam #10320

Merged
merged 4 commits into from
May 28, 2024
Merged

Conversation

jakubdyszkiewicz
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz commented May 27, 2024

Checklist prior to review

IPAM part of the implementation decided in MADR 046.

Still unit tests. Will create e2e tests once we have hostname generator to actually check that we can communicate over DNS -> VIP.

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz marked this pull request as ready for review May 27, 2024 13:06
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner May 27, 2024 13:06
@jakubdyszkiewicz jakubdyszkiewicz requested review from jijiechen, michaelbeaumont and lukidzi and removed request for a team May 27, 2024 13:06
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz enabled auto-merge (squash) May 28, 2024 11:22
@jakubdyszkiewicz jakubdyszkiewicz merged commit 3220769 into kumahq:master May 28, 2024
15 checks passed
@jakubdyszkiewicz jakubdyszkiewicz deleted the feat/ipam-ms branch May 28, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants