Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(GatewayAPI): only enqueue Gateway reconciliations from routes if parent is a Gateway #10316

Merged
merged 3 commits into from
May 28, 2024

Conversation

spacewander
Copy link
Contributor

For example, in GAMMA, the parentRef can also be a Service.
Signed-off-by: spacewander spacewanderlzx@gmail.com

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

For example, in GAMMA, the parentRef can also be a Service.
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander spacewander marked this pull request as ready for review May 25, 2024 12:57
@spacewander spacewander requested a review from a team as a code owner May 25, 2024 12:57
@spacewander spacewander requested review from jijiechen, jakubdyszkiewicz and lukidzi and removed request for a team May 25, 2024 12:57
@michaelbeaumont michaelbeaumont changed the title fix(GatewayAPI): the parentRef of HTTPRoute may not be Gateway fix(GatewayAPI): only enqueue Gateway reconciliations from routes if parent is a Gateway May 25, 2024
spacewander and others added 2 commits May 27, 2024 21:51
Co-authored-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: 罗泽轩 <spacewanderlzx@gmail.com>
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@michaelbeaumont
Copy link
Contributor

Thanks @spacewander !

@michaelbeaumont michaelbeaumont merged commit e90fc3d into kumahq:master May 28, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants