chore(meshhealthcheck): prevent targeting meshexternalservice by vali…

…dation (#11477) Signed-off-by: slonka <slonka@users.noreply.github.com>
kumahq · Sep 20, 2024 · fb97cc3 · fb97cc3
1 parent 6841c37
commit fb97cc3
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 5 deletions.
diff --git a/pkg/plugins/policies/meshhealthcheck/api/v1alpha1/validator.go b/pkg/plugins/policies/meshhealthcheck/api/v1alpha1/validator.go
@@ -40,7 +40,6 @@ func validateTo(topTargetRef common_api.TargetRef, to []To) validators.Validatio
 			SupportedKinds: []common_api.TargetRefKind{
 				common_api.Mesh,
 				common_api.MeshService,
-				common_api.MeshExternalService,
 				common_api.MeshMultiZoneService,
 			},
 		}))

diff --git a/pkg/plugins/policies/meshhealthcheck/api/v1alpha1/validator_test.go b/pkg/plugins/policies/meshhealthcheck/api/v1alpha1/validator_test.go
@@ -82,7 +82,7 @@ to:
       tcp: # it will pick the protocol as described in 'protocol selection' section
         disabled: true # new, default false, can be disabled for override
 `),
-			Entry("to level MeshExternalService", `
+			XEntry("to level MeshExternalService", `
 targetRef:
   kind: Mesh
 to:
@@ -295,7 +295,7 @@ violations:
   - field: spec.to[0].default.http.expectedStatuses[1]
     message: must be in inclusive range [100, 599]`,
 			}),
-			Entry("cannot use MeshExternalService with other type than Mesh", testCase{
+			XEntry("cannot use MeshExternalService with other type than Mesh", testCase{
 				inputYaml: `
 targetRef:
   kind: MeshSubset

diff --git a/pkg/plugins/policies/meshhealthcheck/plugin/v1alpha1/plugin_test.go b/pkg/plugins/policies/meshhealthcheck/plugin/v1alpha1/plugin_test.go
@@ -287,7 +287,7 @@ var _ = Describe("MeshHealthCheck", func() {
 		}),
 	)
 
-	It("should generate correct configuration for MeshExternalService with ZoneEgress", func() {
+	XIt("should generate correct configuration for MeshExternalService with ZoneEgress", func() {
 		// given
 		rs := core_xds.NewResourceSet()
 		rs.Add(&core_xds.Resource{

diff --git a/test/e2e_env/universal/meshexternalservice/meshexternalservice.go b/test/e2e_env/universal/meshexternalservice/meshexternalservice.go
@@ -594,7 +594,7 @@ spec:
 		})
 	})
 
-	Context("MeshExternalService with MeshHealthCheck", func() {
+	XContext("MeshExternalService with MeshHealthCheck", func() {
 		E2EAfterEach(func() {
 			Expect(DeleteMeshResources(universal.Cluster, meshNameNoDefaults,
 				meshhealthcheck_api.MeshHealthCheckResourceTypeDescriptor,