fix(meshpassthrough): do not require port (#10941)

Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
kumahq · Jul 23, 2024 · a3efc86 · a3efc86
1 parent 597b06e
commit a3efc86
Show file tree

Hide file tree

Showing 10 changed files with 1 addition and 19 deletions.
diff --git a/app/kumactl/cmd/install/testdata/install-control-plane.defaults.golden.yaml b/app/kumactl/cmd/install/testdata/install-control-plane.defaults.golden.yaml
@@ -3974,8 +3974,6 @@ spec:
                         value:
                           description: Value for the specified Type.
                           type: string
-                      required:
-                      - port
                       type: object
                     type: array
                   passthroughMode:

diff --git a/app/kumactl/cmd/install/testdata/install-control-plane.gateway-api-present.yaml b/app/kumactl/cmd/install/testdata/install-control-plane.gateway-api-present.yaml
@@ -3974,8 +3974,6 @@ spec:
                         value:
                           description: Value for the specified Type.
                           type: string
-                      required:
-                      - port
                       type: object
                     type: array
                   passthroughMode:

diff --git a/app/kumactl/cmd/install/testdata/install-control-plane.with-helm-set.yaml b/app/kumactl/cmd/install/testdata/install-control-plane.with-helm-set.yaml
@@ -3994,8 +3994,6 @@ spec:
                         value:
                           description: Value for the specified Type.
                           type: string
-                      required:
-                      - port
                       type: object
                     type: array
                   passthroughMode:

diff --git a/app/kumactl/cmd/install/testdata/install-crds.all.golden.yaml b/app/kumactl/cmd/install/testdata/install-crds.all.golden.yaml
@@ -5528,8 +5528,6 @@ spec:
                         value:
                           description: Value for the specified Type.
                           type: string
-                      required:
-                      - port
                       type: object
                     type: array
                   passthroughMode:

diff --git a/deployments/charts/kuma/crds/kuma.io_meshpassthroughs.yaml b/deployments/charts/kuma/crds/kuma.io_meshpassthroughs.yaml
@@ -81,8 +81,6 @@ spec:
                         value:
                           description: Value for the specified Type.
                           type: string
-                      required:
-                      - port
                       type: object
                     type: array
                   passthroughMode:

diff --git a/docs/generated/openapi.yaml b/docs/generated/openapi.yaml
@@ -7248,8 +7248,6 @@ components:
                       value:
                         description: Value for the specified Type.
                         type: string
-                    required:
-                      - port
                     type: object
                   type: array
                 passthroughMode:

diff --git a/docs/generated/raw/crds/kuma.io_meshpassthroughs.yaml b/docs/generated/raw/crds/kuma.io_meshpassthroughs.yaml
@@ -81,8 +81,6 @@ spec:
                         value:
                           description: Value for the specified Type.
                           type: string
-                      required:
-                      - port
                       type: object
                     type: array
                   passthroughMode:

diff --git a/pkg/plugins/policies/meshpassthrough/api/v1alpha1/meshpassthrough.go b/pkg/plugins/policies/meshpassthrough/api/v1alpha1/meshpassthrough.go
@@ -47,7 +47,7 @@ type Match struct {
 	// Value for the specified Type.
 	Value string `json:"value,omitempty"`
 	// Port defines the port to which a user makes a request.
-	Port *int `json:"port"`
+	Port *int `json:"port,omitempty"`
 	// Protocol defines the communication protocol. Possible values: `tcp`, `tls`, `grpc`, `http`, `http2`.
 	// +kubebuilder:default=tcp
 	Protocol ProtocolType `json:"protocol,omitempty"`

diff --git a/pkg/plugins/policies/meshpassthrough/api/v1alpha1/schema.yaml b/pkg/plugins/policies/meshpassthrough/api/v1alpha1/schema.yaml
@@ -51,8 +51,6 @@ properties:
                 value:
                   description: Value for the specified Type.
                   type: string
-              required:
-                - port
               type: object
             type: array
           passthroughMode:

diff --git a/pkg/plugins/policies/meshpassthrough/k8s/crd/kuma.io_meshpassthroughs.yaml b/pkg/plugins/policies/meshpassthrough/k8s/crd/kuma.io_meshpassthroughs.yaml
@@ -81,8 +81,6 @@ spec:
                         value:
                           description: Value for the specified Type.
                           type: string
-                      required:
-                      - port
                       type: object
                     type: array
                   passthroughMode: