fix(MeshService): limit display name to 63 characters (#10719)

The name was being validated to have the given length leading to errors with syncing and the `name.namespace` format on Kubernetes. We actually only need to limit the display name.

See #10474

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>

pkg/core/resources/apis/meshservice/api/v1alpha1/meshservice.go

@@ -27,6 +27,8 @@ type Port struct {
 	AppProtocol core_mesh.Protocol `json:"appProtocol,omitempty"`
 }
 
+const maxNameLength = 63
+
 // MeshService
 // +kuma:policy:is_policy=false
 // +kuma:policy:has_status=true

pkg/core/resources/apis/meshservice/api/v1alpha1/validator.go

@@ -1,13 +1,15 @@
 package v1alpha1
 
 import (
+	"github.com/kumahq/kuma/pkg/core/resources/model"
 	"github.com/kumahq/kuma/pkg/core/validators"
 )
 
 func (r *MeshServiceResource) validate() error {
 	var verr validators.ValidationError
 
-	verr.Add(validators.ValidateLength(validators.RootedAt("name"), 63, r.GetMeta().GetName()))
+	name := model.GetDisplayName(r.GetMeta())
+	verr.Add(validators.ValidateLength(validators.RootedAt("name"), maxNameLength, name))
 
 	return verr.OrNil()
 }

test/e2e_env/multizone/meshservice/sync.go

@@ -83,7 +83,30 @@ spec:
 			Setup(multizone.UniZone2)).To(Succeed())
 
 		err := NewClusterSetup().
+			Setup(multizone.KubeZone1)
+		Expect(err).ToNot(HaveOccurred())
+
+		veryLongNamedService := `
+kind: MeshService
+apiVersion: kuma.io/v1alpha1
+metadata:
+  name: this-service-has-a-name-thats-the-exact-length-allowed-for-svcs
+  namespace: meshservice
+  labels:
+    kuma.io/mesh: meshservice
+spec:
+  selector:
+    dataplaneTags:
+      kuma.io/service: some-service
+  ports:
+  - port: 80
+    targetPort: 80
+    appProtocol: http
+`
+
+		err = NewClusterSetup().
 			Install(NamespaceWithSidecarInjection(namespace)).
+			Install(YamlK8s(veryLongNamedService)).
 			Install(democlient.Install(democlient.WithNamespace(namespace), democlient.WithMesh(meshName))).
 			Setup(multizone.KubeZone2)
 		Expect(err).ToNot(HaveOccurred())
@@ -185,6 +208,25 @@ spec:
 		}, "30s", "1s").Should(Succeed())
 	})
 
+	It("should sync MeshServices with a long name", func() {
+		hashedName := hash.HashedName(meshName, "this-service-has-a-name-thats-the-exact-length-allowed-for-svcs", "kuma-2", "meshservice")
+		// MeshServices are synced to global zone without conflict
+		Eventually(func(g Gomega) {
+			_, _, err := msStatus(multizone.Global, hashedName)
+			g.Expect(err).ToNot(HaveOccurred())
+		}, "30s", "1s").Should(Succeed())
+
+		// MeshServices are synced to other zone without conflict
+		Eventually(func(g Gomega) {
+			_, _, err := msStatus(multizone.KubeZone1, fmt.Sprintf("%s.%s", hashedName, Config.KumaNamespace))
+			g.Expect(err).ToNot(HaveOccurred())
+		}, "30s", "1s").Should(Succeed())
+		Eventually(func(g Gomega) {
+			_, _, err := msStatus(multizone.UniZone2, hashedName)
+			g.Expect(err).ToNot(HaveOccurred())
+		}, "30s", "1s").Should(Succeed())
+	})
+
 	mzStatus := func(cluster Cluster, name string) (*meshmzservice_api.MeshMultiZoneServiceStatus, error) {
 		out, err := cluster.GetKumactlOptions().RunKumactlAndGetOutput("get", "meshmultizoneservice", "-m", meshName, hash.HashedName(meshName, name), "-ojson")
 		if err != nil {