Fixed by Does not respect table alias on join clause

[osyo-manga]

Fixed by Does not respect table alias on join clause #24

before

class Company < ActiveRecord::Base
  include ActiveRecord::Bitemporal
  has_many  :employees,  foreign_key: :company_id, autosave: true
end

class Employee < ActiveRecord::Base
  include ActiveRecord::Bitemporal
  belongs_to :company
end

p Company.joins(:employees).left_joins(:employees).where(employees: { bitemporal_id: employee.id }).count
# => 3

puts Company.joins(:employees).left_joins(:employees).where(employees: { bitemporal_id: employee.id }).to_sql
# => SELECT "companies".*
#      FROM "companies"
#     INNER JOIN "employees"
#        ON "employees"."company_id"           =  "companies"."bitemporal_id"
#       AND "employees"."valid_from"           <= '2019-05-13 08:40:40.496312'
#       AND "employees"."valid_to"             >  '2019-05-13 08:40:40.496312'
#       AND "employees"."deleted_at" IS NULL
#      LEFT OUTER JOIN "employees" "employees_companies"
#        ON "employees_companies"."company_id" =  "companies"."bitemporal_id"
#       AND "employees"."valid_from"           <= '2019-05-13 08:40:40.496426'
#       AND "employees"."valid_to"             >  '2019-05-13 08:40:40.496426'
#       AND "employees"."deleted_at" IS NULL
#     WHERE "companies"."valid_from"           <= '2019-05-13 08:40:40.496468'
#       AND "companies"."valid_to"             >  '2019-05-13 08:40:40.496468'
#       AND "companies"."deleted_at" IS NULL
#       AND "employees"."bitemporal_id"        =  1

after

class Company < ActiveRecord::Base
  include ActiveRecord::Bitemporal
  has_many  :employees,  foreign_key: :company_id, autosave: true
end

class Employee < ActiveRecord::Base
  include ActiveRecord::Bitemporal
  belongs_to :company
end

p Company.joins(:employees).left_joins(:employees).where(employees: { bitemporal_id: employee.id }).count
# => 1

puts Company.joins(:employees).left_joins(:employees).where(employees: { bitemporal_id: employee.id }).to_sql
# => SELECT "companies".*
#      FROM "companies"
#     INNER JOIN "employees"
#        ON "employees"."company_id"           =  "companies"."bitemporal_id"
#       AND "employees"."valid_from"           <= '2019-05-13 08:39:50.504885'
#       AND "employees"."valid_to"             >  '2019-05-13 08:39:50.504885'
#       AND "employees"."deleted_at" IS NULL
#      LEFT OUTER JOIN "employees" "employees_companies"
#        ON "employees_companies"."company_id" =  "companies"."bitemporal_id"
#       AND "employees_companies"."valid_from" <= '2019-05-13 08:39:50.504984'
#       AND "employees_companies"."valid_to"   >  '2019-05-13 08:39:50.504984'
#       AND "employees_companies"."deleted_at" IS NULL
#     WHERE "companies"."valid_from"           <= '2019-05-13 08:39:50.505018'
#       AND "companies"."valid_to"             >  '2019-05-13 08:39:50.505018'
#       AND "companies"."deleted_at" IS NULL
#       AND "employees"."bitemporal_id"        =  1

[meganemura]

LGTM 🎉

[f440]

👍

[osyo-manga]

@meganemura @f440 Thanks! :)