Skip to content
This repository was archived by the owner on May 28, 2024. It is now read-only.

Conversation

@7eben
Copy link
Contributor

@7eben 7eben commented Jun 22, 2022

No description provided.

@7eben 7eben added the wip Work in progress label Jun 22, 2022
@7eben 7eben requested a review from jrpedrianes June 22, 2022 09:31
@7eben 7eben removed the wip Work in progress label Jul 4, 2022
@7eben 7eben changed the title WIP [KF-334] User Action Document [KF-334] User Action Document Jul 4, 2022
default:
$ref: "#/components/responses/DefaultError"

/processes/{id}/~actions/save-user-action-value-document:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, but maybe here we should use: /processes/{id}/~actions/save-user-action-document:

🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, I left it like that for homogeneity with that of element...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

save-element-value-document:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yap, but a user action can't have more than one value, isn't it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just thinking

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nop, only one value

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why I commented that 'value' is redundant, 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, but maybe is better left as is, as you have it, to avoid confusion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know about the naming, but now is the right moment to make any change because later is a new API version :S

@7eben 7eben merged commit 72d2164 into main Jul 5, 2022
@7eben 7eben deleted the feature/KF-334-add-user-action-element branch July 5, 2022 06:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants