Skip to content

Download coursier if missing #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Download coursier if missing #104

wants to merge 4 commits into from

Conversation

kubukoz
Copy link
Owner

@kubukoz kubukoz commented Oct 1, 2022

  • Fetch coursier if missing
  • Update instructions

@kubukoz kubukoz mentioned this pull request Oct 1, 2022
Open
2 tasks
kubukoz
kubukoz commented Feb 17, 2023
View reviewed changes
README.md
1. Make sure you have [Coursier](https://get-coursier.io/docs/cli-installation) available on the PATH as `cs`, running Java 11 or above
2. Get the extension from [Marketplace](https://marketplace.visualstudio.com/items?itemName=kubukoz.smithy-playground)
3. Create a file, `smithy-build.json`. Example:
<!-- todo: does coursier install a jvm if needed? try it in docker -->
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big todo

kubukoz
kubukoz commented Feb 17, 2023
View reviewed changes
vscode-extension/src/extension.ts
@@ -18,6 +19,8 @@ export function activate(context: ExtensionContext) {
"smithyql"
);

const coursierBinary = await getCoursierExecutable(context.extensionPath);
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be integration tested

kubukoz
kubukoz commented Feb 17, 2023
View reviewed changes
vscode-extension/src/extension.ts
@@ -38,7 +41,7 @@ export function activate(context: ExtensionContext) {
"smithyPlayground",
"Smithy Playground",
{
command: "cs",
command:coursierBinary,
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kubukoz