Fails to Parse String Containing Commas

[cryptodeal]

When parsing a yaml document containing a string that contains a comma, it returnserror.Unhandled.

Example yaml:

data:
  splits_string: 900,50,50

The error is thrown here: https://github.com/kubkon/zig-yaml/blob/main/src/parse.zig#L467

When catching the error/logging the value of the token, it's failing at the first comma in the string.

Expected behavior per yaml spec, this should be parsed as a string.

[AndrewOvvv]

Hi there,

I think the issue you mentioned has already been resolved. Here is an example of code that should work fine with the ",".

const std = @import("std");
const yaml = @import("yaml");

const source =
    \\names: [ John Doe, MacIntosh, Jane Austin ]
    \\numbers:
    \\  - 10
    \\  - -8
    \\  - 6
    \\nested:
    \\  some: one,two,three
    \\  wick: john doe
    \\finally: [ 8.17,
    \\           19.78      , 17 ,
    \\           21 ]
;

const Simple = struct {
    names: []const []const u8,
    numbers: []const i16,
    nested: struct {
        some: []const u8,
        wick: []const u8,
    },
    finally: [4]f16,
};

pub fn main() !void {
    var gpa = std.heap.GeneralPurposeAllocator(.{}){};
    const allocator = gpa.allocator();
    var typed = try yaml.Yaml.load(allocator, source);
    defer typed.deinit();

    const simple = try typed.parse(Simple);
    std.debug.print("{s}\n", .{simple.nested.some});
}

Output:

$ zig13 build -Doptimize=ReleaseSafe run
one,two,three

Can you please resolve this issue? (You can check your example yourself to ensure that the issue has been resolved.)

[kubkon]

Do we have a test for this? I am happy to accept a contribution adding a test and resolving this issue.