Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support reservation #62

Merged
merged 5 commits into from
Oct 22, 2024
Merged

support reservation #62

merged 5 commits into from
Oct 22, 2024

Conversation

lzlaa
Copy link
Collaborator

@lzlaa lzlaa commented Aug 29, 2024

No description provided.

binacs
binacs reviewed Sep 6, 2024
View reviewed changes
Copy link
Member

@binacs binacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! LGTM overall just a few comments

cmd/scheduler/app/options/options.go Outdated Show resolved Hide resolved
manifests/quickstart-feature-examples/godel-demo-default.yaml Show resolved Hide resolved
pkg/binder/utils/reservation.go Outdated Show resolved Hide resolved
pkg/binder/utils/reservation.go Outdated Show resolved Hide resolved
pkg/scheduler/eventhandlers.go Show resolved Hide resolved
pkg/scheduler/framework/handle/handle.go Show resolved Hide resolved
pkg/util/resource_constants.go Outdated Show resolved Hide resolved
@lzlaa lzlaa force-pushed the dev/support-reservation branch 2 times, most recently from 890575a to 60bfc95 Compare September 10, 2024 11:31
@lzlaa lzlaa force-pushed the dev/support-reservation branch 2 times, most recently from af5a097 to da3cc83 Compare September 19, 2024 09:27
binacs
binacs previously approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@binacs binacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lzlaa lzlaa changed the title WIP: support reservation support reservation Sep 20, 2024
@lzlaa lzlaa requested a review from sxy390 as a code owner September 23, 2024 08:39
binacs
binacs previously approved these changes Oct 13, 2024
View reviewed changes
Copy link
Member

@binacs binacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@NickrenREN NickrenREN merged commit e52b029 into main Oct 22, 2024
5 checks passed
@NickrenREN NickrenREN deleted the dev/support-reservation branch October 29, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zryfish zryfish zryfish approved these changes

@binacs binacs binacs left review comments

@XinyiSong XinyiSong Awaiting requested review from XinyiSong XinyiSong is a code owner

@Liumeng-lambert Liumeng-lambert Awaiting requested review from Liumeng-lambert Liumeng-lambert is a code owner

@yuey002 yuey002 Awaiting requested review from yuey002 yuey002 is a code owner

@lintongj lintongj Awaiting requested review from lintongj lintongj is a code owner

@NickrenREN NickrenREN Awaiting requested review from NickrenREN NickrenREN is a code owner

@sxy390 sxy390 Awaiting requested review from sxy390 sxy390 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lzlaa @zryfish @binacs @NickrenREN