fix(tests): Don't expect a json in stdout from kwctl anymore #28
Conversation
Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
There was a problem hiding this comment.
LGTM, I just wonder if bats assertions are available here:
https://github.com/ztombol/bats-assert?tab=readme-ov-file#partial-matching
@kravciak tried locally in Debian and NixOS, and couldn't get it to work; cannot reliably load bats-support (following https://bats-core.readthedocs.io/en/stable/writing-tests.html#bats-load-library-load-system-wide-libraries, https://github.com/ztombol/bats-docs?tab=readme-ov-file#loading). It feels too system-dependent. Given that we need to support contributors and first-time users, it may not be a good fit for user-facing repos. It's a pity, because it would be a nice addition :/. |
Description
Relates to kubewarden/kubewarden-controller#838.
Test
Tested locally, e2e tests don't run on CI right now.
Additional Information
Tradeoff
Potential improvement