Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: grant access to minikube/k3d #450

Merged
merged 2 commits into from
Mar 16, 2023

Conversation

flavio
Copy link
Member

@flavio flavio commented Mar 15, 2023

kwctl is built using rustls enabled. Unfortunately rustls does not support validating IP addresses yet (see kube-rs/kube#1003).

This commit introduces a workaround to address this limitation. This is required to make sure users can run context aware policies against minikube, k3d and other local development solution that deploy kubernetes in this way.

@flavio flavio requested a review from a team as a code owner March 15, 2023 17:36
@flavio flavio self-assigned this Mar 15, 2023
Copy link
Member

@viccuad viccuad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Needs the clippy warnings fixed now, though.

@flavio
Copy link
Member Author

flavio commented Mar 15, 2023

LGTM! Needs the clippy warnings fixed now, though.

doh... I'll handle that and merge it once everything is green

Copy link
Member

@jvanz jvanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the red CI jobs, LGTM

@flavio flavio force-pushed the context-aware branch 4 times, most recently from 38c41bd to b498cb0 Compare March 15, 2023 20:48
kwctl is built using rustls enabled. Unfortunately rustls does not support
validating IP addresses yet (see kube-rs/kube#1003).

This commit introduces a workaround to address this limitation. This is
required to make sure users can run context aware policies against
minikube, k3d and other local development solution that deploy
kubernetes in this way.

Signed-off-by: Flavio Castelli <fcastelli@suse.com>
Address clippy warnings

Signed-off-by: Flavio Castelli <fcastelli@suse.com>
@flavio flavio merged commit fb76ef4 into kubewarden:context-aware Mar 16, 2023
@flavio flavio deleted the context-aware branch March 16, 2023 08:59
viccuad pushed a commit to viccuad/kwctl that referenced this pull request Aug 13, 2024
Signed-off-by: Sergio Castaño Arteaga <tegioz@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants