Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yuval moved on, don't add him to reviews #126

Merged
merged 1 commit into from
Jun 25, 2019
Merged

Conversation

rmohr
Copy link
Member

@rmohr rmohr commented Jun 25, 2019

No description provided.

@kubevirt-bot kubevirt-bot requested review from booxter and stu-gott June 25, 2019 08:06
@rmohr
Copy link
Member Author

rmohr commented Jun 25, 2019

@yuvalif sorry for the noise in your inbox.

@rmohr
Copy link
Member Author

rmohr commented Jun 25, 2019

/cc @slintes

@kubevirt-bot kubevirt-bot requested a review from slintes June 25, 2019 14:57
@cynepco3hahue
Copy link

/approve
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2019
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cynepco3hahue

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2019
@kubevirt-bot kubevirt-bot merged commit 54c5d74 into kubevirt:master Jun 25, 2019
gabrielecerami pushed a commit to gabrielecerami/project-infra that referenced this pull request Oct 7, 2020
Do avoid creation of too many OKD providers, we will have single OKD-4.1
provider and we will advance it minor version under the hood.

This PR introduces some additional improvements:
- adding CPU manager static flag to worker nodes.
- add possibility to create additional workers via `--workers` flag.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants