add PendingPopulation DataVolume phase #2729
Conversation
Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
kubevirt-bot
added
release-note-none
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awels The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/hold Verifying kubevirt usage |
kubevirt-bot
added
the
do-not-merge/hold
| @@ -366,6 +366,9 @@ const ( | |||
|
|
|||
| // WaitForFirstConsumer represents a data volume with a current phase of WaitForFirstConsumer | |||
| WaitForFirstConsumer DataVolumePhase = "WaitForFirstConsumer" | |||
| // PendingPopulation represents a data volume which should be populated by | |||
| // the CDI populators but havn't created the pvc' yet | |||
There was a problem hiding this comment.
Typo: havn't. Since we want to merge this as soon as possible I guess it can be fixed in the next related PR.
There was a problem hiding this comment.
that's what I get for copying Shelly's code!
There was a problem hiding this comment.
don't get me started on your 'native English speaker' PR typos ;)
|
/unhold |
kubevirt-bot
added
size/S
and removed
do-not-merge/hold
…lated IsPopulated still valid and used elsewhere Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
mhenriks
force-pushed
the
pop-pending-phase
branch
from
30c1631 to
205f884
Compare
|
/lgtm |
|
/test pull-containerized-data-importer-e2e-upg |
What this PR does / why we need it:
kubevirt/kubevirt has to be aware of/handle this phase before it can consume a version of CDI that uses populators internally. By "handle", I mean that it is okay start the VM if a DV is in this state.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: