Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove old generated crds before creating new ones #2699

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

mhenriks
Copy link
Member

What this PR does / why we need it:

Discoverd this when I was going back/forth testing populator PRs

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS labels Apr 21, 2023
@kubevirt-bot kubevirt-bot requested review from aglitke and awels April 21, 2023 15:17
Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
Copy link
Contributor

@ShellyKa13 ShellyKa13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2023
@mhenriks
Copy link
Member Author

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mhenriks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2023
@akalenyu
Copy link
Collaborator

/test pull-containerized-data-importer-fossa
networking err

@akalenyu
Copy link
Collaborator

Now that fossa actually checks stuff we get a GPL issue

GPL-3.0-only license detected in github.com/docker/docker@v20.10.12

I don't get why it's only showing up now, we seem to be using this version for a while
/cc @awels

@awels
Copy link
Member

awels commented Apr 25, 2023

/test pull-containerized-data-importer-fossa

@kubevirt-bot kubevirt-bot merged commit 94fe963 into kubevirt:main Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants