Follow up for WFFC test suite adjustments

[akalenyu]

What this PR does / why we need it:
Previous PR does not make our test suite completely WFFC-friendly,
as it turns out more follow-ups were needed.
This continues the work in #2610

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

[awels]

/lgtm
/approve

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [awels]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[akalenyu]

/hold

testing the changes

[alromeros]

Nice!
/lgtm

[ShellyKa13]

/lgtm

[alromeros]

Any reason to remove this?

[akalenyu]

Yeah, I am trying to find out why we have it in the first place, seems to date back 5+ years
basically means verifier won't attempt to restart on transient errs

I have some tests where the verifier pod regularly hits an error without much context,
and does not recover from it

[akalenyu]

Changed to OnFailure so it only restarts if it exits with a return code other than 0
(default is Always - pod must always be running)

[akalenyu]

@alromeros @awels I put this change in a separate commit, think it deserves it.
I wanted to have your thoughts on this one as it is not trivial

[alromeros]

I think it makes perfect sense to change it to RestartPolicyOnFailure, but like you, I lack some context on why we had RestartPolicyNever before. If it's not breaking anything I'm for the change.

[awels]

What transient errors are we thinking. we would like to know if the verifier pod errors (like maybe the file we are looking for doesn't exist). This would simply restart the failed command, which may or may not fail again depending on if the error is transient or a real issue. If we do this, we need to make sure there are some time limits on the commands we run in the verifier pod.

[akalenyu]

I am hitting errors in container startup (not in executing commands on it)
Seems to be related to quick recreation of the deleted verifier pod, but not sure, error does not say much,
the container just fails to spin up and doesn't retry.

Is there a reason to go with RestartPolicyNever? If you feel this is too offensive I will remove the second commit
and we can proceed with this PR without this change

[awels]

We can try with the on failure policy, we will know if something breaks due to it, there is an overall suite timeout anyway.

[akalenyu]

/hold

testing the changes

Just a clarification, I am testing this change against an external cluster with LVM Storage

[akalenyu]

/hold cancel

[awels]

/test pull-containerized-data-importer-fossa

[awels]

/lgtm

[akalenyu]

/test pull-containerized-data-importer-fossa

[akalenyu]

/retest

[akalenyu]

/cherrypick release-v1.56

[kubevirt-bot]

@akalenyu: new pull request created: #2649

In response to this:

/cherrypick release-v1.56

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[akalenyu]

/cherrypick release-v1.55

[kubevirt-bot]

@akalenyu: #2633 failed to apply on top of branch "release-v1.55":

Applying: Follow up for WFFC test suite adjustments
Using index info to reconstruct a base tree...
M	tests/cloner_test.go
M	tests/csiclone_test.go
M	tests/datavolume_test.go
A	tests/external_population_test.go
M	tests/import_test.go
M	tests/smartclone_test.go
Falling back to patching base and 3-way merge...
Auto-merging tests/smartclone_test.go
Auto-merging tests/import_test.go
CONFLICT (modify/delete): tests/external_population_test.go deleted in HEAD and modified in Follow up for WFFC test suite adjustments. Version Follow up for WFFC test suite adjustments of tests/external_population_test.go left in tree.
Auto-merging tests/datavolume_test.go
Auto-merging tests/csiclone_test.go
Auto-merging tests/cloner_test.go
CONFLICT (content): Merge conflict in tests/cloner_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Follow up for WFFC test suite adjustments
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-v1.55

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.