Add clone from VolumeSnapshot docs #2574
Conversation
kubevirt-bot
added
release-note-none
akalenyu
force-pushed
the
clone-from-snap-docs
branch
3 times, most recently
from
f7ca231 to
2ce1d3e
Compare
| One examples is ceph, where this would be about utilizing RBD layering. | ||
| A much simpler example would be storage that can take around 5-10 minutes to snapshot a 200GB volume. | ||
|
|
||
| ### Note: Data Volume cloning from snapshot source can work together with namespace transfer and size expansion |
There was a problem hiding this comment.
Note is usually marked with > or * not as another headline i.e ###
| * Create the restore PVC | ||
| * Set the claim reference of the PV to point to the new target PVC | ||
| - If not possible: | ||
| * Attempt [host-assisted cloning](./clone-datavolume.md) between 2 PVCs where CDI creates a temporary restore PVC from the snapshot to act as the source. |
There was a problem hiding this comment.
I'm not sure I understand, you write this Attempt under the if not possible which refers to if not possible to restore from said snapshot yet here you write that you create a temp restore PVC to do regular host assisted clone. what did I miss?
There was a problem hiding this comment.
Yeah this is confusing, added Check if restore from said snapshot to desired target is possible to tackle
Consider someone cloning a target that has a different provisioner. We can still restore from the snapshot and attempt host assisted
The idea is that we provide a "complete" clone from volumesnapshot package
| - DataVolume is created with a Snapshot source | ||
| - Check if restore from said snapshot is possible (as described in Prerequisites): | ||
| - If possible: | ||
| * Create the restore PVC |
There was a problem hiding this comment.
maybe mentions that this is a temp PVC that will be deleted after?
| - Check if restore from said snapshot is possible (as described in Prerequisites): | ||
| - If possible: | ||
| * Create the restore PVC | ||
| * Set the claim reference of the PV to point to the new target PVC |
There was a problem hiding this comment.
maybe mention that you change the claim ref of the restore PV from the restore PVC to the target PVC?
There was a problem hiding this comment.
I added a link to ns transfer doc
| spec: | ||
| source: | ||
| http: | ||
| url: http://.../Fedora-Cloud-Base-34-1.2.x86_64.qcow2 |
There was a problem hiding this comment.
consider using an actual path that the user can try and use?
Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
akalenyu
force-pushed
the
clone-from-snap-docs
branch
from
2ce1d3e to
acaa016
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mhenriks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/test pull-containerized-data-importer-e2e-destructive |
1 similar comment
|
/test pull-containerized-data-importer-e2e-destructive |
Signed-off-by: Alex Kalenyuk akalenyu@redhat.com
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: