Add DV garbage collection doc #2408
Conversation
Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
kubevirt-bot
added
release-note-none
| @@ -16,8 +16,8 @@ CDI configuration in specified by administrators in the `spec.config` of the `CD | |||
| | preallocation | nil | Preallocation setting to use unless a per-dataVolume value is set | | |||
| | importProxy | nil | The proxy configuration to be used by the importer pod when accessing a http data source. When the ImportProxy is empty, the Cluster Wide-Proxy (Openshift) configurations are used. ImportProxy has four parameters: `ImportProxy.HTTPProxy` that defines the proxy http url, the `ImportProxy.HTTPSProxy` that determines the roxy https url, and the `ImportProxy.NoProxy` which enforce that a list of hostnames and/or CIDRs will be not proxied, and finally, the `ImportProxy.TrustedCAProxy`, the ConfigMap name of an user-provided trusted certificate authority (CA) bundle to be added to the importer pod CA bundle. | | |||
| | insecureRegistries | nil | List of TLS disabled registries. | | |||
|
|
|||
|
|
|||
| | dataVolumeTTLSeconds | nil | Time after DataVolume completion it can be garbage collected. | | |||
There was a problem hiding this comment.
Maybe Time in seconds following DataVolume completion after which it can be garbage-collected but not insisting
There was a problem hiding this comment.
I prefer the shorter version. in seconds already appears in the field name :)
kubevirt-bot
added
dco-signoff: no
|
I think you can close this issue with this PR: |
kubevirt-bot
added
dco-signoff: yes
Co-authored-by: akalenyu <51477153+akalenyu@users.noreply.github.com> Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
|
/lgtm |
|
/test pull-containerized-data-importer-e2e-hpp-latest |
|
/retest-required |
doc/datavolumes.md
Outdated
|
|
||
| Why is this an improvement over simply looking at the state annotation created and managed by CDI? Data Volumes provide a versioned API that other projects like [Kubevirt](https://github.com/kubevirt/kubevirt) can integrate with. This way those projects can rely on an API staying the same for a particular version and have guarantees about what that API will look like. Any changes to the API will result in a new version of the API. | ||
|
|
||
| ### Garbage collection of successfully completed DataVolumes | ||
| Once the PVC population process is completed, its corresponding DV can be either garbage collected or remain. GC can be dynamically configured in [CDIConfig](cdi-config.md), so we recommend users not to assume the DV exists after completion. When the desired PVC exists, but its DV does not exist, it means that the PVC was successfully populated and the DV was garbage collected. To prevent a DV from being garbage collected, it should be annotated with: |
There was a problem hiding this comment.
I am kind of missing the motivation of why we would want the DVs garbage collected. Its great that it happens, but why? I would mention something that once the PVC is fully populated the DV no longer server a purpose, and it sometimes confuses people thinking they should modify the DV to have the matching PVC react. In particular resizing PVCs seems to confuse people because they see the DV.
Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
kubevirt-bot
added
size/M
and removed
lgtm
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awels The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
Signed-off-by: Arnon Gilboa agilboa@redhat.com
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #2311
Special notes for your reviewer:
Release note: