Queue DataVolumes referred to in "populatedFor" annotations

[mhenriks]

Signed-off-by: Michael Henriksen mhenriks@redhat.com

What this PR does / why we need it:

This issue came up in testing backup/restore with Kasten k10. Should queue DataVolumes referred to in "populatedFor" annotations. Without this change, a "prePopulated" DV created before a "populatedFor" DV will be pending forever if the PVC is not owned by the DV.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

[mhenriks]

/retest

[brybacki]

I can see that you changed the watcher to also get PVCs with populatedFor.
But what was the actual problem, and what is actually fixed. Can you improve the description of the PR?

[mhenriks]

I can see that you changed the watcher to also get PVCs with populatedFor. But what was the actual problem, and what is actually fixed. Can you improve the description of the PR?

Sorry, thought it was pretty obvious if you look at the difference to the functional test. The reason the test worked before is because the PVC was owned by the DataVolume. But that will not always be the case (at least initially). Without this change the PVC (without owner ref) would leave the DV pending forever.

[mhenriks]

/hold
while I figure out test failures with GC enabled

[mhenriks]

/retest

[mhenriks]

/test pull-containerized-data-importer-e2e-ceph-gc

[ShellyKa13]

/lgtm

[mhenriks]

/hold cancel
/approve

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mhenriks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mhenriks]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mhenriks]

/cherry-pick release-v1.49

[kubevirt-bot]

@mhenriks: #2373 failed to apply on top of branch "release-v1.49":

Applying: Queue DataVolumes referred to in "populatedFor" annotations
Using index info to reconstruct a base tree...
M	pkg/controller/datavolume-controller.go
M	tests/datavolume_test.go
Falling back to patching base and 3-way merge...
Auto-merging tests/datavolume_test.go
CONFLICT (content): Merge conflict in tests/datavolume_test.go
Auto-merging pkg/controller/datavolume-controller.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Queue DataVolumes referred to in "populatedFor" annotations
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-v1.49

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.