Skip to content

Conversation

awels
Copy link
Member

@awels awels commented Feb 3, 2021

Signed-off-by: Alexander Wels awels@redhat.com

What this PR does / why we need it:
With the dockerhub rate limit, we are seeing a lot of CI failures due to rate limits on dockerhub. This PR makes it so we release on quay.io instead which doesn't have the rate limit.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

Signed-off-by: Alexander Wels <awels@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/M labels Feb 3, 2021
@coveralls
Copy link

Coverage Status

Coverage remained the same at 73.958% when pulling 88c7534 on awels:move_to_quay into a6c9f19 on kubevirt:master.

@@ -16,11 +16,15 @@ go_library(

go_test(
name = "go_default_test",
srcs = ["feature-gates_test.go"],
srcs = [
"feature-gates_suite_test.go",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

;)

@brybacki
Copy link
Contributor

brybacki commented Feb 5, 2021

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2021
@awels
Copy link
Member Author

awels commented Feb 5, 2021

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2021
@awels
Copy link
Member Author

awels commented Feb 5, 2021

/test pull-containerized-data-importer-e2e-k8s-1.18-upg

@kubevirt-bot kubevirt-bot merged commit 9d5c6f3 into kubevirt:master Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants