The type of DeleteResource is changed to pointer #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #307 +/- ##
==========================================
+ Coverage 77.87% 77.93% +0.06%
==========================================
Files 20 20
Lines 1410 1414 +4
==========================================
+ Hits 1098 1102 +4
Misses 245 245
Partials 67 67
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
leason00
changed the title
Signed-off-by: lisen <lisen@youzan.com>
|
@leason00 Great job! Please increase the code coverage:) |
leason00
added a commit
to leason00/community
that referenced
this pull request
May 24, 2022
I'm a contributor from YouZan that uses Kubevela to manage apps and terraform-controller to manage resources. I have been actively contributing to KubeVela cloud resource, and the three pr have been merged kubevela/terraform-controller#307 kubevela/terraform-controller#300 kubevela/terraform-controller#262
leason00
added a commit
to leason00/community
that referenced
this pull request
May 24, 2022
I'm a contributor from YouZan that uses Kubevela to manage apps and terraform-controller to manage resources. I have been actively contributing to KubeVela cloud resource, and the three pr have been merged kubevela/terraform-controller#307 kubevela/terraform-controller#300 kubevela/terraform-controller#262 Signed-off-by: lisen <lisen@youzan.com>
wonderflow
pushed a commit
to kubevela/community
that referenced
this pull request
May 24, 2022
I'm a contributor from YouZan that uses Kubevela to manage apps and terraform-controller to manage resources. I have been actively contributing to KubeVela cloud resource, and the three pr have been merged kubevela/terraform-controller#307 kubevela/terraform-controller#300 kubevela/terraform-controller#262 Signed-off-by: lisen <lisen@youzan.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#306
Signed-off-by: lisen lisen@youzan.com