Skip to content
This repository was archived by the owner on Apr 28, 2026. It is now read-only.

update: replace drag-and-drop with selection-based UI for binding pol…#925

Merged
kubestellar-prow[bot] merged 1 commit into
kubestellar:devfrom
priyanshuharshbodhi1:update/workload-and-cluster-selection
Jun 4, 2025
Merged

update: replace drag-and-drop with selection-based UI for binding pol…#925
kubestellar-prow[bot] merged 1 commit into
kubestellar:devfrom
priyanshuharshbodhi1:update/workload-and-cluster-selection

Conversation

@priyanshuharshbodhi1
Copy link
Copy Markdown
Contributor

@priyanshuharshbodhi1 priyanshuharshbodhi1 commented May 27, 2025

Description

Fixes #923 - Removed all references to "drag" functionality in the binding policies UI since we no longer support drag and drop.

@kubestellar-prow kubestellar-prow Bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 27, 2025
@kubestellar-prow
Copy link
Copy Markdown

kubestellar-prow Bot commented May 27, 2025

Hi @priyanshuharshbodhi1. Thanks for your PR.

I'm waiting for a kubestellar member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@priyanshuharshbodhi1
Copy link
Copy Markdown
Contributor Author

priyanshuharshbodhi1 commented May 27, 2025

@clubanderson PTAL!

@priyanshuharshbodhi1
Copy link
Copy Markdown
Contributor Author

priyanshuharshbodhi1 commented May 27, 2025

After BP update:

image
image
image
image
image

@clubanderson
Copy link
Copy Markdown
Contributor

clubanderson commented May 27, 2025

good job. @MAVRICK-1 will review in the next couple of days.

@kunal-511
Copy link
Copy Markdown
Contributor

kunal-511 commented May 28, 2025

@priyanshuharshbodhi1 Can you also work on renaming the component names also to make all of the consistent

@priyanshuharshbodhi1
Copy link
Copy Markdown
Contributor Author

priyanshuharshbodhi1 commented May 28, 2025

@kunal-511 I guess all drag and drop components are updated.

@kunal-511
Copy link
Copy Markdown
Contributor

kunal-511 commented May 28, 2025

@priyanshuharshbodhi1 Can you also work on renaming the component names also to make all of the consistent

This is pending I guess

@clubanderson
Copy link
Copy Markdown
Contributor

clubanderson commented May 28, 2025

/ok-to-test

@kubestellar-prow kubestellar-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 28, 2025
@kunal-511
Copy link
Copy Markdown
Contributor

kunal-511 commented May 28, 2025

@priyanshuharshbodhi1 any update ?

@priyanshuharshbodhi1
Copy link
Copy Markdown
Contributor Author

priyanshuharshbodhi1 commented May 29, 2025

@priyanshuharshbodhi1 any update ?

Will complete it by the EOD.

@clubanderson clubanderson requested a review from kunal-511 May 30, 2025 13:32
@kunal-511
Copy link
Copy Markdown
Contributor

kunal-511 commented May 30, 2025

Any updates??

@priyanshuharshbodhi1
Copy link
Copy Markdown
Contributor Author

priyanshuharshbodhi1 commented May 31, 2025

umm, I am busy with my assignment, will complete it after that.

@kunal-511
Copy link
Copy Markdown
Contributor

kunal-511 commented May 31, 2025

umm, I am busy with my assignment, will complete it after that.

Okay lets merge this one you can create new pr for that

@kunal-511
Copy link
Copy Markdown
Contributor

kunal-511 commented May 31, 2025

umm, I am busy with my assignment, will complete it after that.

Okay lets merge this one you can create new pr for that

I think there are many changes we can do to remove the drag keyword from the code but let's do that in other PR

@kunal-511
Copy link
Copy Markdown
Contributor

kunal-511 commented May 31, 2025

@MAVRICK-1 @clubanderson /lgtm

@clubanderson
Copy link
Copy Markdown
Contributor

clubanderson commented May 31, 2025

Can't merge until tests are passed

@kunal-511
Copy link
Copy Markdown
Contributor

kunal-511 commented Jun 2, 2025

Can't merge until tests are passed

@priyanshuharshbodhi1 Please re base this branch because after your PR i have fixed the tests.
Please do this asap

@priyanshuharshbodhi1 priyanshuharshbodhi1 force-pushed the update/workload-and-cluster-selection branch from 1592f9c to 0c15249 Compare June 3, 2025 16:24
@priyanshuharshbodhi1
Copy link
Copy Markdown
Contributor Author

priyanshuharshbodhi1 commented Jun 3, 2025

@kunal-511 PTAL!

@kubestellar-prow kubestellar-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2025
@kubestellar-prow
Copy link
Copy Markdown

kubestellar-prow Bot commented Jun 4, 2025

LGTM label has been added.

DetailsGit tree hash: 07c7dde1793e539f14b2393740ad3f12bf1c4656

@clubanderson
Copy link
Copy Markdown
Contributor

clubanderson commented Jun 4, 2025

/lgtm
/approve

@kubestellar-prow
Copy link
Copy Markdown

kubestellar-prow Bot commented Jun 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clubanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2025
@kubestellar-prow kubestellar-prow Bot merged commit 44f4296 into kubestellar:dev Jun 4, 2025
10 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in KubeStellar UI Project Jun 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kunal-511 kunal-511 Awaiting requested review from kunal-511

Assignees

@clubanderson clubanderson

@kunal-511 kunal-511

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. frontend lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

KubeStellar UI Project
Status: Done

Milestone

No milestone

3 participants

@priyanshuharshbodhi1 @clubanderson @kunal-511