Skip to content

Conversation

@alokdangre
Copy link
Contributor

Description

Added POM for its section, covering all exsisting files under ITS tests

Related Issue

Fixes #2175

Changes Made

  • Updated ...
  • Refactored ...
  • Fixed ...
  • Added tests for ...

Checklist

Please ensure the following before submitting your PR:

  • I have reviewed the project's contribution guidelines.
  • I have written unit tests for the changes (if applicable).
  • I have updated the documentation (if applicable).
  • I have tested the changes locally and ensured they work as expected.
  • My code follows the project's coding standards.

Screenshots or Logs (if applicable)

Additional Notes

Copilot AI review requested due to automatic review settings November 13, 2025 06:10
@kubestellar-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a Page Object Model (POM) for the ITS (Infrastructure Tracking System) section to improve test maintainability and reduce code duplication. The refactoring consolidates common test patterns and locators into a reusable ITSPage class.

Key Changes:

  • Created ITSPage class with comprehensive locators and helper methods for ITS page interactions
  • Refactored 5 test specification files to use the new POM, reducing test code by ~50%
  • Added AuthHelper and MSWHelper integration for streamlined test setup

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 16 comments.

Show a summary per file
File Description
frontend/e2e/pages/index.ts Exports the new ITSPage class for use in test files
frontend/e2e/pages/ITSPage.ts Defines the ITSPage POM with locators and helper methods for ITS page testing
frontend/e2e/ITSTableFeature.spec.ts Refactored to use ITSPage POM, replacing direct page interactions
frontend/e2e/ITSLabelsAndFilters.spec.ts Refactored to use ITSPage POM for label and filter testing
frontend/e2e/ITSImportCluster.spec.ts Refactored to use ITSPage POM for cluster import workflows
frontend/e2e/ITSClusterActions.spec.ts Refactored to use ITSPage POM for cluster action testing
frontend/e2e/ITS.spec.ts Refactored to use ITSPage POM for general ITS page tests

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@alokdangre
Copy link
Contributor Author

/cc @btwshivam

@kubestellar-prow kubestellar-prow bot requested a review from btwshivam November 13, 2025 11:23
@btwshivam btwshivam requested a review from Copilot November 13, 2025 15:30
Copilot finished reviewing on behalf of btwshivam November 13, 2025 15:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

[FEATURE]: Implement Page Object Model for ITS Page

1 participant