-
Notifications
You must be signed in to change notification settings - Fork 206
Added POM for ITS Page #2212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Added POM for ITS Page #2212
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a Page Object Model (POM) for the ITS (Infrastructure Tracking System) section to improve test maintainability and reduce code duplication. The refactoring consolidates common test patterns and locators into a reusable ITSPage class.
Key Changes:
- Created ITSPage class with comprehensive locators and helper methods for ITS page interactions
- Refactored 5 test specification files to use the new POM, reducing test code by ~50%
- Added AuthHelper and MSWHelper integration for streamlined test setup
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 16 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/e2e/pages/index.ts | Exports the new ITSPage class for use in test files |
| frontend/e2e/pages/ITSPage.ts | Defines the ITSPage POM with locators and helper methods for ITS page testing |
| frontend/e2e/ITSTableFeature.spec.ts | Refactored to use ITSPage POM, replacing direct page interactions |
| frontend/e2e/ITSLabelsAndFilters.spec.ts | Refactored to use ITSPage POM for label and filter testing |
| frontend/e2e/ITSImportCluster.spec.ts | Refactored to use ITSPage POM for cluster import workflows |
| frontend/e2e/ITSClusterActions.spec.ts | Refactored to use ITSPage POM for cluster action testing |
| frontend/e2e/ITS.spec.ts | Refactored to use ITSPage POM for general ITS page tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/cc @btwshivam |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
Added POM for its section, covering all exsisting files under ITS tests
Related Issue
Fixes #2175
Changes Made
Checklist
Please ensure the following before submitting your PR:
Screenshots or Logs (if applicable)
Additional Notes