Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci-bot] Sync feature branch to master/feature directory #2400

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

github-actions[bot]
Copy link
Contributor

This PR syncs the feature branch to the master/feature directory.

none

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: github-actions[bot]
Once this PR has been reviewed and has the lgtm label, please assign pixiake for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubesphere-prow kubesphere-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 11, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
15 Security Hotspots
4.5% Duplication on New Code (required ≤ 3%)
C Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

metadata:
labels: {{ include "common.labels" . | nindent 8 }}
app: kk-operator
spec:

Check warning

Code scanning / SonarCloud

Service account permissions should be restricted Medium

Set automountServiceAccountToken to false for this specification of kind Deployment. See more on SonarCloud
schedulerName: {{ .Values.operator.schedulerName }}
terminationGracePeriodSeconds: {{ .Values.operator.terminationGracePeriodSeconds }}
containers:
- name: ks-controller-manager

Check warning

Code scanning / SonarCloud

Storage limits should be enforced Medium

Specify a storage limit for this container. See more on SonarCloud
- pipelines
- pipelines/status
verbs:
- "*"

Check warning

Code scanning / SonarCloud

Wildcards should not be used to define RBAC permissions Medium

Do not use wildcards when defining RBAC permissions. See more on SonarCloud
resources:
- leases
verbs:
- "*"

Check warning

Code scanning / SonarCloud

Wildcards should not be used to define RBAC permissions Medium

Do not use wildcards when defining RBAC permissions. See more on SonarCloud
resources:
- events
verbs:
- "*"

Check warning

Code scanning / SonarCloud

Wildcards should not be used to define RBAC permissions Medium

Do not use wildcards when defining RBAC permissions. See more on SonarCloud
@pixiake pixiake merged commit fe55978 into master Sep 11, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant