Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent admin user to be deleted by helm #1787

Merged
merged 1 commit into from
Oct 29, 2021
Merged

fix: prevent admin user to be deleted by helm #1787

merged 1 commit into from
Oct 29, 2021

Conversation

RolandMa1986
Copy link
Member

Signed-off-by: Roland.Ma rolandma@kubesphere.io

Admin User will be deleted when re-run ks-install if the helm.sh/resource-policy: keep annotation removed by accident. So we need always ensure admin user has this annotation.

/cc @pixiake @zryfish

Signed-off-by: Roland.Ma <rolandma@kubesphere.io>
@ks-ci-bot ks-ci-bot requested review from pixiake and zryfish October 28, 2021 12:04
@RolandMa1986 RolandMa1986 changed the title fix: prevent admin us toer be deleted by helm fix: prevent admin user to be deleted by helm Oct 28, 2021
@ks-ci-bot ks-ci-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 28, 2021
@pixiake
Copy link
Collaborator

pixiake commented Oct 29, 2021

/cherrypick release-3.2

@ks-ci-bot
Copy link
Collaborator

@pixiake: once the present PR merges, I will cherry-pick it on top of release-3.2 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pixiake
Copy link
Collaborator

pixiake commented Oct 29, 2021

/approve
/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2021
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 46018919f0858df5e1bceb3cb25a704cd12bfcbe

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pixiake, RolandMa1986

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2021
@ks-ci-bot ks-ci-bot merged commit abf9acc into kubesphere:master Oct 29, 2021
@ks-ci-bot
Copy link
Collaborator

@pixiake: new pull request created: #1789

In response to this:

/cherrypick release-3.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants