Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rectify suffix to -1.16 for golang16 agent #51

Merged
merged 2 commits into from
Nov 8, 2021

Conversation

JohnNiang
Copy link
Member

What this PR dose?

Rectify suffix to -1.16 for golang16 agent.

Why we need it?

Please see #46.

Which issue dose this PR fix?

Fix #46.

/kind bug

Signed-off-by: John Niang <johnniang@fastmail.com>
@ks-ci-bot ks-ci-bot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 29, 2021
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JohnNiang
To complete the pull request process, please assign linuxsuren after the PR has been reviewed.
You can assign the PR to them by writing /assign @linuxsuren in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 29, 2021
@JohnNiang
Copy link
Member Author

/cc @kubesphere/sig-devops

@ks-ci-bot ks-ci-bot requested a review from a team October 29, 2021 09:20
@JohnNiang JohnNiang closed this Oct 29, 2021
@JohnNiang JohnNiang reopened this Oct 29, 2021
@JohnNiang
Copy link
Member Author

/ping @kubesphere/sig-devops

Copy link
Member

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider, the CI errors have no relation to these changes. I'm going to give it an approval.

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2021
@LinuxSuRen LinuxSuRen merged commit 2590cd9 into kubesphere:master Nov 8, 2021
@JohnNiang JohnNiang deleted the bug/incorrect-tag branch November 8, 2021 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weird image tag "3.2.0-alpha.01.16" and "master1.16" of "kubespheredev/builder-go"
3 participants