Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gradle (6.9.1) agent #45

Merged
merged 4 commits into from
Nov 8, 2021

Conversation

yuezhuangshi
Copy link
Contributor

fix #25

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yuezhuangshi
To complete the pull request process, please assign shaowenchen after the PR has been reviewed.
You can assign the PR to them by writing /assign @shaowenchen in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 11, 2021
@yuezhuangshi
Copy link
Contributor Author

Hi @LinuxSuRen , Pipeline failed due to

#7 0.157 --2021-10-14 01:49:57--  https://mirrors.edge.kernel.org/pub/software/scm/git/git-2.9.5.tar.gz
#7 0.167 Resolving mirrors.edge.kernel.org (mirrors.edge.kernel.org)... 147.75.197.195, 2604:1380:1:3600::1
#7 0.172 Connecting to mirrors.edge.kernel.org (mirrors.edge.kernel.org)|147.75.197.195|:443... connected.
#7 0.198 ERROR: cannot verify mirrors.edge.kernel.org's certificate, issued by '/C=US/O=Let\'s Encrypt/CN=R3':
#7 0.198   Issued certificate has expired.
#7 0.198 To connect to mirrors.edge.kernel.org insecurely, use `--no-check-certificate'.

Should we add --no-check-certificate flag for git installtion? What do you think?

@LinuxSuRen
Copy link
Member

Should we add --no-check-certificate flag for git installtion? What do you think?

I prefer to do not to ignore the potential security issues. It's better to find a way to fix it.

@yuezhuangshi
Copy link
Contributor Author

Should we add --no-check-certificate flag for git installtion? What do you think?

I prefer to do not to ignore the potential security issues. It's better to find a way to fix it.

Maybe we should wait for the maintainer to update site certificate and try again

@LinuxSuRen
Copy link
Member

Maybe we should wait for the maintainer to update site certificate and try again

This is also an option.

@LinuxSuRen LinuxSuRen closed this Nov 8, 2021
@LinuxSuRen LinuxSuRen reopened this Nov 8, 2021
Copy link
Member

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2021
@LinuxSuRen LinuxSuRen changed the title Add gradle agent Add gradle (6.9.1) agent Nov 8, 2021
@LinuxSuRen LinuxSuRen merged commit 6ca0432 into kubesphere:master Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request to have gradle agent image
3 participants