Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Able to fetch all refs for the git repos #28

Merged
merged 1 commit into from
Nov 6, 2021

Conversation

LinuxSuRen
Copy link
Contributor

fix the wrong release checking

fix the wrong release checking
@LinuxSuRen LinuxSuRen added the bug Something isn't working label Nov 6, 2021
@ks-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: LinuxSuRen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

Codecov Report

Merging #28 (e25f1a0) into master (8edf741) will decrease coverage by 0.61%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
- Coverage   17.93%   17.32%   -0.62%     
==========================================
  Files          10       10              
  Lines         368      381      +13     
==========================================
  Hits           66       66              
- Misses        302      315      +13     
Flag Coverage Δ
unittests 17.32% <0.00%> (-0.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controllers/git.go 6.87% <0.00%> (-0.56%) ⬇️
controllers/internal_scm/factory.go 22.22% <0.00%> (-0.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8edf741...e25f1a0. Read the comment docs.

@LinuxSuRen LinuxSuRen merged commit c50287d into kubesphere-sigs:master Nov 6, 2021
@LinuxSuRen LinuxSuRen deleted the fix-git-fetch branch November 6, 2021 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants