Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(): New UTs for SliceValidationWebhook #202

Merged
merged 6 commits into from
Apr 18, 2024

Conversation

priyank-upadhyay
Copy link
Member

@priyank-upadhyay priyank-upadhyay commented Apr 5, 2024

Description

Unit tests for NoNetwork scenarios

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit test cases.

Does this PR introduce a breaking change for other components like worker-operator?


Signed-off-by: Priyank Upadhyay <priyank@aveshasystems.com>
@priyank-upadhyay priyank-upadhyay marked this pull request as ready for review April 18, 2024 06:37
Signed-off-by: Priyank Upadhyay <priyank@aveshasystems.com>
@priyank-upadhyay
Copy link
Member Author

❯ make unit-test
go test -gcflags=-l ./service --coverprofile=coverage.out
ok      github.com/kubeslice/kubeslice-controller/service       1.649s  coverage: 80.2% of statements

@priyank-upadhyay priyank-upadhyay merged commit 97566d4 into master Apr 18, 2024
8 checks passed
@priyank-upadhyay priyank-upadhyay deleted the feature-no-comm-unit-tests branch April 18, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants