Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): fix merge issues #3656

Merged
merged 1 commit into from
Feb 16, 2024
Merged

fix(cli): fix merge issues #3656

merged 1 commit into from
Feb 16, 2024

Conversation

schoren
Copy link
Contributor

@schoren schoren commented Feb 16, 2024

This PR fixes some issues caused by an incorrect merge

Changes

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Loom video

Add your loom video here if your work can be visualized

@schoren schoren requested a review from mathnogueira February 16, 2024 18:55
Copy link

vercel bot commented Feb 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tracetest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2024 6:56pm

@schoren schoren merged commit 4d1f6c1 into main Feb 16, 2024
39 checks passed
@schoren schoren deleted the fix-cli-merge-issues branch February 16, 2024 19:12
@@ -4,6 +4,7 @@ import (
"context"
"os"

"github.com/davecgh/go-spew/spew"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep spew? I noticed that we tried to remove it on this commit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah damn, good catch. fixed on main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants