Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: posthog improvements #3235

Merged
merged 5 commits into from
Oct 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions web/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion web/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"markdown-it": "13.0.1",
"parse-curl": "0.2.6",
"path-browserify": "1.0.1",
"posthog-js": "1.75.3",
"posthog-js": "1.82.3",
"postman-collection": "4.1.4",
"protobufjs": "7.2.4",
"query-string": "7.1.1",
Expand Down
13 changes: 8 additions & 5 deletions web/src/App.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import * as Sentry from '@sentry/react';
import {HistoryRouter} from 'redux-first-history/rr6';

import CaptureWrapper from 'components/CaptureWrapper';
import CustomizationWrapper from 'components/CustomizationWrapper';
import DashboardWrapper from 'components/DashboardWrapper';
import ErrorBoundary from 'components/ErrorBoundary';
Expand All @@ -19,11 +20,13 @@ const App = () => (
<Sentry.ErrorBoundary fallback={({error}) => <ErrorBoundary error={error} />}>
<ReduxWrapperProvider>
<HistoryRouter history={history} basename={serverPathPrefix}>
<CustomizationWrapper>
<DashboardWrapper>
<BaseApp />
</DashboardWrapper>
</CustomizationWrapper>
<CaptureWrapper>
<CustomizationWrapper>
<DashboardWrapper>
<BaseApp />
</DashboardWrapper>
</CustomizationWrapper>
</CaptureWrapper>
</HistoryRouter>
</ReduxWrapperProvider>
</Sentry.ErrorBoundary>
Expand Down
22 changes: 22 additions & 0 deletions web/src/components/CaptureWrapper/CaptureWrapper.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
import {PostHogProvider} from 'posthog-js/react';
import Env from 'utils/Env';
import Content from './Content';

const posthogKey = Env.get('posthogKey');

const options = {
api_host: 'https://app.posthog.com',
opt_out_capturing_by_default: true,
};

interface IProps {
children: React.ReactNode;
}

const CaptureWrapper = ({children}: IProps) => (
<PostHogProvider apiKey={posthogKey} options={options}>
<Content>{children}</Content>
</PostHogProvider>
);

export default CaptureWrapper;
43 changes: 43 additions & 0 deletions web/src/components/CaptureWrapper/Content.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
import {usePostHog} from 'posthog-js/react';
import CaptureProvider from 'providers/Capture';
import {useCallback, useMemo} from 'react';
import Env from 'utils/Env';

const appVersion = Env.get('appVersion');
const env = Env.get('env');
const serverID = Env.get('serverID');
const isAnalyticsEnabled = () => Env.get('analyticsEnabled') && !Env.get('isTracetestDev');

interface IProps {
children: React.ReactNode;
}

const Content = ({children}: IProps) => {
const posthog = usePostHog();

const load = useCallback(() => {
if (!isAnalyticsEnabled()) {
if (posthog?.has_opted_in_capturing()) {
posthog?.opt_out_capturing();
}
return;
}

posthog?.opt_in_capturing();
posthog?._start_queue_if_opted_in();
posthog?.identify(serverID, {
appVersion,
env,
});
}, [posthog]);

const pageView = useCallback(() => {
posthog?.capture('$pageview');
}, [posthog]);

const captureProviderValue = useMemo(() => ({load, pageView}), [load, pageView]);

return <CaptureProvider value={captureProviderValue}>{children}</CaptureProvider>;
};

export default Content;
2 changes: 2 additions & 0 deletions web/src/components/CaptureWrapper/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
// eslint-disable-next-line no-restricted-exports
export {default} from './CaptureWrapper';
6 changes: 5 additions & 1 deletion web/src/components/WithAnalytics/WithAnalytics.tsx
Original file line number Diff line number Diff line change
@@ -1,11 +1,15 @@
import {useCapture} from 'providers/Capture';
import {useEffect} from 'react';
import AnalyticsService from 'services/Analytics/Analytics.service';

const withAnalytics = <P extends object>(Component: React.ComponentType<P>, name: string) => {
const FunctionComponent = (props: P) => {
const {pageView} = useCapture();

useEffect(() => {
pageView();
AnalyticsService.page(name);
}, [props]);
}, [pageView, props]);

return <Component {...props} />;
};
Expand Down
25 changes: 25 additions & 0 deletions web/src/providers/Capture/Capture.provider.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
import noop from 'lodash/noop';
import {createContext, useContext} from 'react';

interface IContext {
load(): void;
pageView(): void;
}

export const Context = createContext<IContext>({
load: noop,
pageView: noop,
});

export const useCapture = () => useContext(Context);

interface IProps {
children: React.ReactNode;
value: IContext;
}

const CaptureProvider = ({children, value}: IProps) => {
return <Context.Provider value={value}>{children}</Context.Provider>;
};

export default CaptureProvider;
2 changes: 2 additions & 0 deletions web/src/providers/Capture/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
// eslint-disable-next-line no-restricted-exports
export {default, useCapture} from './Capture.provider';
5 changes: 4 additions & 1 deletion web/src/providers/SettingsValues/SettingsValues.provider.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import Demo from 'models/Demo.model';
import Linter from 'models/Linter.model';
import Polling from 'models/Polling.model';
import TestRunner from 'models/TestRunner.model';
import {useCapture} from 'providers/Capture';
import TracetestAPI from 'redux/apis/Tracetest';
import {useAppDispatch, useAppSelector} from 'redux/hooks';
import {setUserPreference} from 'redux/slices/User.slice';
Expand Down Expand Up @@ -95,12 +96,14 @@ const SettingsValuesProvider = ({children}: IProps) => {

// Config
const {data: config = Config()} = useGetConfigQuery({});
const {load} = useCapture();

useEffect(() => {
Env.set('analyticsEnabled', config.analyticsEnabled);
AnalyticsService.load();
AnalyticsService.identify();
}, [config]);
load();
}, [config, load]);

// Polling
const {data: pollingProfile = Polling()} = useGetPollingQuery({});
Expand Down
16 changes: 0 additions & 16 deletions web/src/services/Analytics/Analytics.service.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import {AnalyticsBrowser} from '@segment/analytics-next';
import posthog from 'posthog-js';
import {Categories} from 'constants/Analytics.constants';
import Env from 'utils/Env';

Expand All @@ -8,7 +7,6 @@ const appVersion = Env.get('appVersion');
const env = Env.get('env');
const serverID = Env.get('serverID');
const measurementId = Env.get('measurementId');
const posthogKey = Env.get('posthogKey');

export const analytics = new AnalyticsBrowser();

Expand Down Expand Up @@ -37,8 +35,6 @@ const AnalyticsService = (): TAnalyticsService => ({
appVersion,
env,
});

posthog.capture('$pageview');
},
identify() {
if (!isAnalyticsEnabled()) return;
Expand All @@ -47,17 +43,6 @@ const AnalyticsService = (): TAnalyticsService => ({
appVersion,
env,
});

posthog.init(posthogKey, {
api_host: 'https://app.posthog.com',
loaded: ph => {
ph.identify(serverID, {appVersion, env});
},
});

if (posthog.has_opted_out_capturing()) {
posthog.opt_in_capturing();
}
},
load() {
const isSegmentLoaded = Env.get('segmentLoaded');
Expand All @@ -70,7 +55,6 @@ const AnalyticsService = (): TAnalyticsService => ({

if (!isAnalyticsEnabled() && isSegmentLoaded) {
analytics.reset();
posthog.persistence && posthog.opt_out_capturing();
Env.set('segmentLoaded', false);
}
},
Expand Down