Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cicd): remove CI pipeline external infra dependencies #2403

Merged
merged 25 commits into from
Jun 5, 2023
Merged

chore(cicd): remove CI pipeline external infra dependencies #2403

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
a0297bc
test
schoren Apr 18, 2023
41c76a1
fix
schoren May 30, 2023
12895cf
testing e2e fix
xoscar May 30, 2023
4be5865
removing parallel e2e tests
xoscar May 30, 2023
c5f2ce4
adding npm command
xoscar May 30, 2023
4cacd45
fixing pokeshop url variable
xoscar May 30, 2023
3869fd8
update scripts
schoren Jun 1, 2023
c49093d
use faster npm install in makefile
schoren Jun 1, 2023
3adea55
fix tests
schoren Jun 1, 2023
09d565d
add some docs
schoren Jun 1, 2023
9b10410
configure default values for e2e cli
schoren Jun 1, 2023
df9be85
change tracetest_command env to tracetest_cli for consistency
schoren Jun 1, 2023
7ae22e2
fix e2e wait for env
schoren Jun 1, 2023
16382cf
import image before cli e2e
schoren Jun 1, 2023
f1c3885
fix cypress run.sh and add doc
schoren Jun 1, 2023
08cea9c
fix cypress ci
schoren Jun 1, 2023
510932b
fix go+docker cache
schoren Jun 1, 2023
5a0c26c
wait for pokeshop grpc endpoint
schoren Jun 1, 2023
4f6c618
more wait for services
schoren Jun 1, 2023
35cd7e2
implement check retry
schoren Jun 1, 2023
2c5b49e
Updating CLI run tests with a delay
danielbdias Jun 2, 2023
110d284
Update CONTRIBUTING.md
schoren Jun 2, 2023
c57bbaf
fix makefile dockerimage default tag
schoren Jun 2, 2023
26c635a
more makefile fixes
schoren Jun 2, 2023
f753542
enforce startup order
schoren Jun 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
change tracetest_command env to tracetest_cli for consistency
  • Loading branch information
@schoren
schoren committed Jun 2, 2023
commit df9be850d71c42e30a49e12b2406f34d7d22a5e3
2 changes: 1 addition & 1 deletion .github/workflows/pull-request.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ jobs:
find ./dist -name 'tracetest' -exec cp {} ./dist \;
chmod +x ./dist/tracetest

export TRACETEST_COMMAND=$PWD/dist/tracetest
export TRACETEST_CLI=$PWD/dist/tracetest
export TEST_ENVIRONMENT=jaeger
export TAG=pr-${{ github.event.pull_request.number }}

Expand Down
2 changes: 1 addition & 1 deletion testing/cli-e2etest/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
TRACETEST_COMMAND?="../../dist/tracetest"
TRACETEST_CLI?="../../dist/tracetest"
TEST_ENVIRONMENT?="jaeger"
TAG?="dev"

Expand Down
2 changes: 1 addition & 1 deletion testing/cli-e2etest/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ func GetConfigAsEnvVars() *EnvironmentVars {

enableCLIDebug := (os.Getenv("ENABLE_CLI_DEBUG") == "true")

tracetestCommand := os.Getenv("TRACETEST_COMMAND")
tracetestCommand := os.Getenv("TRACETEST_CLI")
if tracetestCommand == "" {
tracetestCommand = "tracetest"
}
Expand Down