feat(frontend): integrate config settings with API #2108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgeepc
force-pushed
the
2100-integrate-config-api
branch
2 times, most recently
from
1cadfdf to
44849b7
Compare
jorgeepc
commented
Mar 7, 2023
| @@ -0,0 +1,30 @@ | |||
| import {EResourceType, TListResponse, TResource} from 'types/Settings.types'; | |||
|
|
|||
| export type TRawConfig = { | |||
There was a problem hiding this comment.
We should replace these types with the OpenAPI generated types
jorgeepc
force-pushed
the
2100-integrate-config-api
branch
from
44849b7 to
8599ba3
Compare
xoscar
approved these changes
Mar 8, 2023
| // Config | ||
| const {data: config = Config()} = useGetConfigQuery({}); | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
I like this, but let's make sure we don't forget this provider and this side effect is the one handling the analytics switch
xoscar
reviewed
Mar 8, 2023
web/public/index.html
Outdated
| analytics.load(window.ENV.measurementId); | ||
| }}(); | ||
| } | ||
| !function(){var analytics=window.analytics=window.analytics||[];if(!analytics.initialize)if(analytics.invoked)window.console&&console.error&&console.error("Segment snippet included twice.");else{analytics.invoked=!0;analytics.methods=["trackSubmit","trackClick","trackLink","trackForm","pageview","identify","reset","group","track","ready","alias","debug","page","once","off","on","addSourceMiddleware","addIntegrationMiddleware","setAnonymousId","addDestinationMiddleware"];analytics.factory=function(e){return function(){var t=Array.prototype.slice.call(arguments);t.unshift(e);analytics.push(t);return analytics}};for(var e=0;e<analytics.methods.length;e++){var key=analytics.methods[e];analytics[key]=analytics.factory(key)}analytics.load=function(key,e){var t=document.createElement("script");t.type="text/javascript";t.async=!0;t.src="https://cdn.segment.com/analytics.js/v1/" + key + "/analytics.min.js";var n=document.getElementsByTagName("script")[0];n.parentNode.insertBefore(t,n);analytics._loadOptions=e};analytics._writeKey="X2vwYODI1vb8g6QpzL9OBxuv5vK7dGan";analytics.SNIPPET_VERSION="4.15.3"; |
There was a problem hiding this comment.
QQ do we know for sure that by just loading the script we are not sending any telemetry data?
I want to clarify if the user updates the flag but still after a refresh this scripts sends something we don't want/expect
xoscar
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates analytics (config) settings with the resources API.
Changes
analyticsEnabledflag from API to trigger web eventsFixes
Checklist