Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): adding documentation on how to contribute with Tracetest (related to #1761) #1820

Merged
merged 3 commits into from
Jan 12, 2023

Conversation

danielbdias
Copy link
Contributor

This PR aims to document how any newcomer can contribute to Tracetest.

Changes

  • Adding CONTRIBUTING.md file
  • Adding reference on how to contribute to README.md

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jfermi jfermi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some editing suggestions.

Co-authored-by: Julianne Fermi <julianne@kubeshop.io>
@danielbdias
Copy link
Contributor Author

Addressing suggestions, thanks @jfermi 😄 !

CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Contributor

@mathnogueira mathnogueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment on the docs section. @jfermi should take a look at this too.

Co-authored-by: Matheus Nogueira <matheus.nogueira2008@gmail.com>
@jfermi
Copy link
Contributor

jfermi commented Jan 12, 2023 via email

@danielbdias danielbdias merged commit c209562 into main Jan 12, 2023
@danielbdias danielbdias deleted the add/contributing-md branch January 12, 2023 15:54
Copy link
Collaborator

@kdhamric kdhamric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants