Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): fix eslint config and enable it in CI #1681

Merged
merged 3 commits into from
Dec 14, 2022
Merged

Conversation

jorgeepc
Copy link
Contributor

This PR fixes our broken eslint config and enables it as part of our CI pipeline.

Changes

  • Fix eslint config

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Screenshots

Screenshot 2022-12-13 at 16 46 05

@jorgeepc jorgeepc self-assigned this Dec 13, 2022
@jorgeepc jorgeepc requested a review from xoscar December 13, 2022 21:50
@@ -76,7 +76,7 @@ module.exports = {
'no-implicit-coercion': [
'error',
{
boolean: true,
boolean: false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Copy link
Contributor

@xoscar xoscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GREAT JOB!

@jorgeepc jorgeepc merged commit 7c91453 into main Dec 14, 2022
@jorgeepc jorgeepc deleted the fix-eslint-config branch December 14, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants