1405 [Transactions] Display parsed value when hovering over Interpolations#1405 #1447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…play-parsed-value-when-hovering-over-interpolations
…1405-transactions-display-parsed-value-when-hovering-over-interpolations
xoscar
changed the base branch from
main
to
1427-transactions-create-parse-statement-service
xoscar
commented
Nov 1, 2022
| @@ -24,6 +24,7 @@ JsonPath {"json_path '" Identifier "'"} | |||
| Pipe {"|"} | |||
| Number { @digit+ } | |||
| Comparator {"=" | "contains" | "!=" | "<" | ">" | "<=" | ">=" | "not-contains" } | |||
| Duration { Number ("." Number)? ("ns" | "us" | "ms"| "s"| "m" | "h") } | |||
There was a problem hiding this comment.
Adding the duration token that was missing 🥴
…1405-transactions-display-parsed-value-when-hovering-over-interpolations
…thub.com:kubeshop/tracetest into 1427-transactions-create-parse-statement-service
…1405-transactions-display-parsed-value-when-hovering-over-interpolations
Base automatically changed from
1427-transactions-create-parse-statement-service
to
main
November 1, 2022 19:36
…hovering-over-interpolations
…hovering-over-interpolations
jorgeepc
approved these changes
Nov 1, 2022
| @@ -50,6 +64,18 @@ export const AssertionCheck = ({field, index, name, remove, form, assertions, at | |||
| [assertions, attributeList, form, name] | |||
| ); | |||
|
|
|||
| const selector = Form.useWatch('selector') || ''; | |||
| const editorContext = useMemo(() => { | |||
| const [spanId = ''] = spanIdList; | |||
There was a problem hiding this comment.
Why do we need the first spanId?
There was a problem hiding this comment.
Yeah, I'm going to add a TODO here, we have the same issue as when we auto-complete the expected value with first span info, even if there can be something from a different one. I'm going to bring this to the rest of the team.
| @@ -52,6 +52,8 @@ export const GridContainer = styled.div` | |||
|
|
|||
| export const CheckItemContainer = styled.div` | |||
| padding: 10px 12px 10px 42px; | |||
|
|
|||
…hovering-over-interpolations
xoscar
deleted the
1405-transactions-display-parsed-value-when-hovering-over-interpolations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR wires up the parse expressions service to the FE by displaying the interpolated values when hovering over inputs.
It is available for both Expressions and Interpolation editors and can be used by passing context to the editor component.
Changes
Fixes
Checklist
https://www.loom.com/share/be6aaf7ca74440d4ad87888b122b80f6